-
Notifications
You must be signed in to change notification settings - Fork 101
Add format parameter when receiving/creating or updating notebook definitions #560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hei, |
This will need to wait until after fabcon. Only bugfixes and features relevant to fabcon are being taken up now. |
Thanks for adding the A few minor points:
|
hi @m-kovalsky , thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a simple code-simplification. then will approve & merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
adding format parameter for get_notebook_definition, create_notebook and update_notebook_definition
when format parameter is not provided the notebook definition should be GIT friendly
if format = 'ipynb' is provided then the definition should be standard ipynb which is a json file
fixed issues with encoding the content within create_notebook and update_notebook_definition functions