Skip to content

Move Microsoft.ServiceFabric.Diagnostics project to GitHub #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 10, 2025

Conversation

ilijagrbic
Copy link
Contributor

We will need to consume SF metrics API on GitHub. This is setup work to enable us to move Microsoft.ServiceFabric.Telemetry project to GitHub as well.

@ilijagrbic ilijagrbic requested review from olegsych and plave0 April 3, 2025 15:34
@ilijagrbic
Copy link
Contributor Author

@ilijagrbic please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement
@microsoft-github-policy-service agree company="Microsoft"

@ilijagrbic ilijagrbic marked this pull request as ready for review April 3, 2025 16:00
Copy link
Member

@olegsych olegsych left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @ilijagrbic. I've added a few requests in the comments. The main criteria for completion of this PR is the appearance of the Microsoft.ServiceFabric.Diagnostics.dll in the SF.ActorsServices.Internal.nupkg produced by the build.

Copy link
Member

@olegsych olegsych left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes on the GitHub side look good @ilijagrbic. Could you cross link it with the WindowsFabric PR? It would be great to review them both at the same time before we merge.

@ilijagrbic ilijagrbic merged commit eafc185 into develop Apr 10, 2025
2 checks passed
@ilijagrbic ilijagrbic deleted the user/ilijagrbi/moveSFDiagnostics branch April 10, 2025 07:15
ilijagrbic added a commit that referenced this pull request Apr 10, 2025
@ilijagrbic ilijagrbic restored the user/ilijagrbi/moveSFDiagnostics branch April 10, 2025 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants