-
Notifications
You must be signed in to change notification settings - Fork 111
Move Microsoft.ServiceFabric.Diagnostics project to GitHub #401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @ilijagrbic. I've added a few requests in the comments. The main criteria for completion of this PR is the appearance of the Microsoft.ServiceFabric.Diagnostics.dll in the SF.ActorsServices.Internal.nupkg produced by the build.
src/Microsoft.ServiceFabric.Diagnostics/Microsoft.ServiceFabric.Diagnostics.csproj
Outdated
Show resolved
Hide resolved
src/Microsoft.ServiceFabric.Diagnostics/Microsoft.ServiceFabric.Diagnostics.csproj
Show resolved
Hide resolved
src/Microsoft.ServiceFabric.Diagnostics/Microsoft.ServiceFabric.Diagnostics.csproj
Outdated
Show resolved
Hide resolved
src/Microsoft.ServiceFabric.Diagnostics/Tracing/Config/SettingsConfigReader.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.ServiceFabric.Diagnostics/Microsoft.ServiceFabric.Diagnostics.csproj
Outdated
Show resolved
Hide resolved
src/Microsoft.ServiceFabric.Diagnostics/Microsoft.ServiceFabric.Diagnostics.csproj
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes on the GitHub side look good @ilijagrbic. Could you cross link it with the WindowsFabric PR? It would be great to review them both at the same time before we merge.
)" This reverts commit eafc185.
We will need to consume SF metrics API on GitHub. This is setup work to enable us to move Microsoft.ServiceFabric.Telemetry project to GitHub as well.