Align python_requires, addition of requirements-dev.txt #297
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
While setting up the environment to test this repo (specifically in a Kaggle environment), I encountered some dependency conflicts during the
pip install
process [Optional: you could add: "(related to packages likefsspec
being incompatible with pre-installed versions)"].I also noticed the
python_requires
insetup.py
was set to>=3.5
, which differs from the README's recommendation of Python 3.7-3.9.Based on this, I've made two small improvements:
python_requires
insetup.py
: Changed to>=3.7
to better align with the README and common ecosystem versions.requirements-dev.txt
: This separates development-only dependencies (likepytest
,black
,pre-commit
,Sphinx
) from the core ones inrequirements.txt
. It clarifies setup for contributors (e.g., viapip install -r requirements-dev.txt
).Hope this improves setup clarity and consistency! Amazing repo by the way