Skip to content

Align python_requires, addition of requirements-dev.txt #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

KaranSinghDev
Copy link

@KaranSinghDev KaranSinghDev commented Apr 17, 2025

Hi,
While setting up the environment to test this repo (specifically in a Kaggle environment), I encountered some dependency conflicts during the pip install process [Optional: you could add: "(related to packages like fsspec being incompatible with pre-installed versions)"].
I also noticed the python_requires in setup.py was set to >=3.5, which differs from the README's recommendation of Python 3.7-3.9.

Based on this, I've made two small improvements:

  1. Updated python_requires in setup.py: Changed to >=3.7 to better align with the README and common ecosystem versions.
  2. Added requirements-dev.txt: This separates development-only dependencies (like pytest, black, pre-commit, Sphinx) from the core ones in requirements.txt. It clarifies setup for contributors (e.g., via pip install -r requirements-dev.txt).

Hope this improves setup clarity and consistency! Amazing repo by the way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant