-
Notifications
You must be signed in to change notification settings - Fork 1.4k
FIX: Parallel build JSON file issues #13241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
CI failure looks related:
|
Super related. Looks like another test is using the tmp folder that I defined and putting some variables to mne.json that i defined. I solved this. 'MNE_STIM_CHANNEL': 'STI 014', 'SUBJECTS_DIR': 'C:\Users\VssAdministrator\AppData\Local\Temp\pytest-of-VssAdministrator\pytest-0\test_datasets_basic0\mne_data\MNE-fsaverage-data', 'MNE_LOGGING_LEVEL': 'warning', 'MNE_FORCE_SERIAL': 'true'} |
I changed the logic, now we check the complementary set. Should be more robust in case the keys are already present in the mne configuration. I had the impression that CI is running with some parallelisation at the test level (i.e, multiple tests running in parallel), but I am not sure. |
Hey guys @agramfort, @larsoner and @drammock, I think it okay for me now... I just need the confirmation with the tests, but i need the workflows approval to be able to check. |
... one last thing, to fully fix the referenced issue, we'll want to filelock the forward dot product calc code, too mne-python/mne/forward/_lead_dots.py Line 53 in 266ccc9
So we should add that here, or remove the "fixes" tag in the top comment |
Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
Good catch, thank you for pointing. I forgot. Should work now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one tiny tweak to make the logger.info
more informative, committed and marking for merge-when-green, thanks in advance @bruAristimunha !
The CI issue doesnt seems related @larsoner |
Fixes #13139.
What does this implement/fix?
Implementing a small semaphore to ensure we are always writing mne config json correctly even if we have parallel file access. Using filelock as optional dependency.
Additional information
This is affect moabb and braindecode a lot.