-
Notifications
You must be signed in to change notification settings - Fork 88
Make McpJson public to allow flexible protocol development #103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@e5l Hi Leonid, My first time to send PR to this rep. Could you help take a look if I need to do any more change? |
Hey @parnurzeal, thank you for the PR. LGTM. Could you run apiDump and commit the change? |
Thank you @e5l ! Could you guide me a bit how to run apiDump? |
|
Does this mean I am fine to submit this? @e5l |
@parnurzeal |
Right but I just think that it would be better to use the same McpJson as same as other transport implementation. |
@e5l I wonder how to get this to merge? it seems auto-merge hasn't tried to merge up til now. |
Sorry for the delay, I'm going to merge it soon |
This MCP repo allows to create new transport from public
AbstractTransport
butMcpJson
which is main part for parsing (example) instead being private and not visible to use and block the development of new Transport.Motivation and Context
I am trying to create a new transport but got blocked on not being able to encode or decode JSONRPCMessage as McpJSON is not public.
How Has This Been Tested?
Open Intellij project and run tests as per this repo guideline.
Breaking Changes
N/A
Types of changes
Checklist