added MorphToMany with testcases #2640
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
attach MorphToMany working detaching works sync working cleanup
GromNaN
requested changes
Oct 19, 2023
| @@ -41,7 +43,7 @@ trait HybridRelations | |||
| public function hasOne($related, $foreignKey = null, $localKey = null) | |||
| { | |||
| // Check if it is a relation with an original model. | |||
| if (! is_subclass_of($related, MongoDBModel::class)) { | |||
| if (!is_subclass_of($related, MongoDBModel::class)) { | |||
There was a problem hiding this comment.
Our CS requires that there is a space after exclamation mark. I'll revert this changes with phpcbf before merging.
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## 4.1 #2640 +/- ##
============================================
- Coverage 91.04% 89.38% -1.66%
- Complexity 756 818 +62
============================================
Files 35 36 +1
Lines 1931 2110 +179
============================================
+ Hits 1758 1886 +128
- Misses 173 224 +51
|
4 tasks
|
Closing in favor of #2670 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can you give this a try?