Support child nodes on bind element

[kazuki43zoo]

I want to support child nodes(such as <if>, <foreach>, etc ...) on <bind> element.

By this changes, we can write sql map as follow:

<?xml version="1.0" encoding="UTF-8" ?>
<!DOCTYPE mapper PUBLIC "-//mybatis.org//DTD Mapper 3.0//EN"
        "http://mybatis.org/dtd/mybatis-3-mapper.dtd" >
<mapper namespace="com.example.domain.repository.order.OrderRepository">

    <!-- ... -->

    <sql id="selectFromJoin">
        SELECT
            o.id,
            o.status_code,
            os.name AS status_name,
            oi.quantity,
            i.code AS item_code,
            i.name AS item_name,
            i.price AS item_price,
            ct.code AS category_code,
            ct.name AS category_name,
            cp.code AS coupon_code,
            cp.name AS coupon_name,
            cp.price AS coupon_price
        FROM
            ${orderTable} o
        INNER JOIN c_order_status os ON os.code = o.status_code
        INNER JOIN t_order_item oi ON oi.order_id = o.id
        INNER JOIN m_item i ON i.code = oi.item_code
        INNER JOIN m_item_category ic ON ic.item_code = i.code
        INNER JOIN m_category ct ON ct.code = ic.category_code
        LEFT JOIN t_order_coupon oc ON oc.order_id = o.id
        LEFT JOIN m_coupon cp ON cp.code = oc.coupon_code
    </sql>

    <select id="findOne" resultMap="orderResultMap">
        <bind name="orderTable" value="'t_order'" />
        <include refid="selectFromJoin"/>
        WHERE
            o.id = #{id}
        ORDER BY
            item_code ASC,
            category_code ASC,
            coupon_code ASC
    </select>

    <select id="findPage" resultMap="orderResultMap">
        <bind name="orderTable">
            (
            SELECT
                id,
                status_code
            FROM
                t_order
            <where>
                <if test="status != null">
                    status_code = #{status}
                </if>
            </where>
            ORDER BY
                id DESC
            LIMIT #{pageable.pageSize}
            OFFSET #{pageable.offset}
            )
        </bind>
        <include refid="selectFromJoin"/>
        ORDER BY
            id DESC,
            item_code ASC,
            category_code ASC,
            coupon_code ASC
    </select>

    <!-- ... -->

</mapper>

@harawata @emacarron @hazendaz @jeffgbutler
What do you think this idea ?
If you agree with my idea, please review the this PR !!

Thanks.

[harawata]

I think the same can be achieved using <include />.

<sql id="selectFromJoin">
  SELECT
    o.id,
    o.status_code,
    os.name AS status_name,
    oi.quantity,
    i.code AS item_code,
    i.name AS item_name,
    i.price AS item_price,
    ct.code AS category_code,
    ct.name AS category_name,
    cp.code AS coupon_code,
    cp.name AS coupon_name,
    cp.price AS coupon_price
  FROM
    <include refid="${orderTable}" />
    o
  INNER JOIN c_order_status os ON os.code = o.status_code
  INNER JOIN t_order_item oi ON oi.order_id = o.id
  INNER JOIN m_item i ON i.code = oi.item_code
  INNER JOIN m_item_category ic ON ic.item_code = i.code
  INNER JOIN m_category ct ON ct.code = ic.category_code
  LEFT JOIN t_order_coupon oc ON oc.order_id = o.id
  LEFT JOIN m_coupon cp ON cp.code = oc.coupon_code
</sql>

<sql id="orderTablePlain">
  t_order
</sql>

<select id="findOne" resultMap="orderResultMap">
  <include refid="selectFromJoin">
    <property name="orderTable" value="orderTablePlain" />
  </include>
  WHERE
      o.id = #{id}
  ORDER BY
      item_code ASC,
      category_code ASC,
      coupon_code ASC
</select>

<sql id="orderTablePageable">
(
  SELECT
      id,
      status_code
  FROM
      t_order
  <where>
      <if test="status != null">
          status_code = #{status}
      </if>
  </where>
  ORDER BY
      id DESC
  LIMIT #{pageable.pageSize}
  OFFSET #{pageable.offset}
)
</sql>

<select id="findPage" resultMap="orderResultMap">
  <include refid="selectFromJoin">
    <property name="orderTable" value="orderTablePageable" />
  </include>
  ORDER BY
    id DESC,
    item_code ASC,
    category_code ASC,
    coupon_code ASC
</select>

Sorry if I am missing something!

[kazuki43zoo]

@harawata Thanks for your comment.

Your suggestion looks good !!
But i think the dynamic include reference(<include refid="${...}" />) is little complex(difficult) than using bind element for developer that not familiar with MyBatis. (I think using bind element is more intuitive)

WDYT ?

[harawata]

Um...I'm not sure.
@mnesarco @emacarron Could you guys take a look when you have time, please?

[guoweixin]

看到了，只是看一下