Skip to content

feat: add nix packages and dev shell #3316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

elsirion
Copy link

@elsirion elsirion commented May 16, 2025

Description

This PR adds a nix flake with packages for the iroh-dns-server and iroh-relay binaries as well as a rust dev shell for development. To make the packaging work better (less redundant versions in nix flake) I also made the crate versions a workspace property that is inherited.

Breaking Changes

None to my knowledge.

Notes & open questions

  • Should the .envrc file be part of this PR? It automatically activates the dev shell via direnv if set up and allowed.
  • Should the cargo changes be split into a separate commit?
  • Does the nix dev shell need docs? I'd just assume fellow nixers will recognize it being there and be happyy while others will keep doing whatever they were doing before.
  • Longer term, out of scope here imo: should more things like dependencies be moved to the workspace (can recommend, we did that with Fedimint
    and it made changes much more manageable)

Change checklist

  • Self-review.
  • Documentation updates following the style guide, if relevant.
  • Tests if relevant.

This commit adds packages for the iroh-dns-server and iroh-relay
binaries as well as a rust dev shell for development. To make the
packaging work better (less redundant versions in ni flake) I also
made the crate versions a workspace property that is inherited.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏗 In progress
Development

Successfully merging this pull request may close these issues.

1 participant