Skip to content

Update pynestml_frontend.py #1206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mottenmann99
Copy link

@mottenmann99 mottenmann99 commented May 6, 2025

Added module_name to generate_target() parameters within generate_spinnaker_target(), due following error when generating spinnaker-target-code:
[5,GLOBAL, INFO]: No module name specified; the generated module will be named "nestmlmodule"

Copy link

github-actions bot commented May 6, 2025

🐰 Bencher Report

Branch1206/merge
Testbedubuntu-latest
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
seconds (s)
(Result Δ%)
Upper Boundary
seconds (s)
(Limit %)
tests/nest_continuous_benchmarking/test_nest_continuous_benchmarking.py::TestNESTContinuousBenchmarking::test_stdp_nn_synapse📈 view plot
🚷 view threshold
3.83 s
(+4.11%)Baseline: 3.68 s
4.05 s
(94.64%)
BenchmarkLatencyBenchmark Result
seconds (s)
(Result Δ%)
Upper Boundary
seconds (s)
(Limit %)
tests/nest_continuous_benchmarking/test_nest_continuous_benchmarking.py::TestNESTContinuousBenchmarking::test_stdp_nn_synapse📈 view plot
🚷 view threshold
3.16 s
(-13.90%)Baseline: 3.67 s
4.03 s
(78.27%)
BenchmarkLatencyBenchmark Result
seconds (s)
(Result Δ%)
Upper Boundary
seconds (s)
(Limit %)
tests/nest_continuous_benchmarking/test_nest_continuous_benchmarking.py::TestNESTContinuousBenchmarking::test_stdp_nn_synapse📈 view plot
🚷 view threshold
3.16 s
(-13.61%)Baseline: 3.65 s
4.02 s
(78.53%)
🐰 View full continuous benchmarking report in Bencher

@clinssen clinssen self-requested a review May 19, 2025 08:15
@clinssen
Copy link
Contributor

@mottenmann99: before merging this, we should test that the pipeline actually works with a different module name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants