Skip to content

Feature - Share Functionality #2574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 129 commits into
base: main
Choose a base branch
from
Open

Feature - Share Functionality #2574

wants to merge 129 commits into from

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Feb 5, 2025 •
edited
Loading

How to test?

  • User should be able to create, edit, remove and update share for notes.
  • User should be able to open settings of the share and configure it
  • User should be able to send email for note share
  • User should be able to Share internal link

alperozturk96
alperozturk96 commented Feb 5, 2025
View reviewed changes
app/build.gradle
exclude group: 'commons-logging', module: 'commons-logging'
}

implementation("com.github.nextcloud:android-library:2.19.0") {
Copy link
Collaborator Author

@alperozturk96 alperozturk96 Feb 5, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed for

android.lib.resources.shares.OCShare
android.lib.resources.shares.ShareType
...

alperozturk96
alperozturk96 commented Feb 5, 2025
View reviewed changes
app/build.gradle
@@ -95,6 +95,15 @@ ext {
dependencies {
coreLibraryDesugaring 'com.android.tools:desugar_jdk_libs:2.1.4'

implementation 'com.google.guava:guava:31.1-android'
Copy link
Collaborator Author

@alperozturk96 alperozturk96 Feb 5, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed for to fix following build error:

 error: cannot access ListenableFuture
public class SyncWorker extends Worker {
       ^
  class file for com.google.common.util.concurrent.ListenableFuture not found

alperozturk96
alperozturk96 commented Feb 5, 2025
View reviewed changes
app/src/main/AndroidManifest.xml
@@ -11,7 +11,8 @@

<uses-permission android:name="android.permission.INTERNET" />
<uses-permission android:name="android.permission.ACCESS_NETWORK_STATE" />

<uses-permission android:name="android.permission.READ_CONTACTS" />
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed for NoteShareActivity.requestContactPermissionLauncher()

@alperozturk96 alperozturk96 mentioned this pull request Feb 10, 2025
Open
@alperozturk96
add layout
8c5e87f 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
add fragment
f7acd88 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
add some logic
9f825a8 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
add viewholders
612e400 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
add UsersAndGroupsSearchConfig
0dec990 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
add ShareLinkToDialog
547b732 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
add FileDetailSharingMenuBottomSheetDialog
34f4a5a 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
add QuickSharingPermissionsBottomSheetDialog
843fda2 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
add SharePasswordDialogFragment
479124e 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
add RetrieveHoverCardAsyncTask
1847eda 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
first successfull build
12856e9 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
dont use user
a27b91d 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
convert to activity
635ba0e 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
use branded activity
1e12048 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
add share api
35fa976 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
use share api
c2867eb 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
fix parsing for sharee
c4b11ef 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
bind suggestions to UI
9d8c065 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
bind suggestions to UI
e157d86 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
add to-do
484677b 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
Rename .java to .kt
af49ff3 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
add icon for suggestion
b2c7f9f 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
add READ_CONTACTS permission
092ebd2 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
alperozturk96 and others added 22 commits February 17, 2025 17:02
@alperozturk96
check resharing
bd3ef72 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@tobiasKaminsky
Merge pull request #2578 from nextcloud/feature/shared-with-you
fdd8a2b 
Feature - Shared With You
@tobiasKaminsky
Merge pull request #2575 from nextcloud/feature/public-share
3f7c920 
Feature - Public Share
@alperozturk96
add getShareFromNote
8f2bc70 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
check public share permission
5576e04 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
merge master
90ed413 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
merge master
a67fbd7 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
remove unused functions and add todos
7f8cbc7 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
fail fast handleContactResult
01df2e3 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
add FIXME
1a00750 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
fix crashes
0c75ba5 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
fix crashes
4898e09 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
check shareType
2adf41f 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
add loading layout
ca134d9 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
check shares
50c103d 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
add FilesSpecificViewThemeUtils
a0808aa 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
fix toOCShare
e576292 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
fix isHideFileDownload
db6f425 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
solve git conflict
6a279c8 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
solve git conflict
8228c47 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
fix git conflict
dbe2bf1 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
fix git conflict
7bc133a 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@tobiasKaminsky
Copy link
Member

I found one small bug:
for some reason, I do not know how I did it, the share is shown 2x:

image

I created it on Android Notes

@tobiasKaminsky
Copy link
Member

Another bug:
Create share link does nothing for me.
According to web it also does not create it.

alperozturk96 and others added 6 commits April 3, 2025 13:33
@alperozturk96
Merge branch 'main' into feature/internal-share
8cb5ad9
@alperozturk96
simplify
6557a20 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
fix duplication and avatar
ff1527a 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
fix git conflicts
73e7f7d 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
Merge branch 'main' into feature/internal-share
4ef5822
@alperozturk96
inject SharePasswordDialogListener
cce12b8 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

@ZetaTom ZetaTom Awaiting requested review from ZetaTom

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
3. to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alperozturk96 @tobiasKaminsky