-
Notifications
You must be signed in to change notification settings - Fork 680
Add network tags support for Google Batch #5951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for nextflow-docs-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Would not resourceLabels cover this use case? As a user when I should use networkTags instead of resourceLabels? nextflow/plugins/nf-google/src/main/nextflow/cloud/google/batch/GoogleBatchTaskHandler.groovy Line 294 in 5204d27
|
@pditommaso No, they're different things. Network tags are used to apply firewall rules and control network traffic to your instances. Resource labels cannot be used for network security controls and are key-value pairs used for just resource organization (e.g. cost tracking). They're also structured differently in the API: tags are a simple list of strings at the root of the AllocationPolicy ( |
Fair enough. @bentsherman is there not a new annotation for config settings? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- update "maximal spec" test in
GoogleBatchTaskHandlerTest
- add config option to docs
reference/config.md
- add config option to schema
GoogleBatchConfig.java
(use the same description from the docs)
plugins/nf-google/src/main/nextflow/cloud/google/batch/GoogleBatchTaskHandler.groovy
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor language suggestions. Please check meaning is retained.
modules/nf-lang/src/main/java/nextflow/config/scopes/GoogleBatchConfig.java
Outdated
Show resolved
Hide resolved
The only remaining issue is the DCO signoff. @ejseqera if you click on the failing check it will take you to instructions for how to fix the DCO. I think you will have to rebase the branch. Don't worry about overwriting our commits if you need to |
9898e7c
to
c8a8a4c
Compare
92b672d
to
071a3ef
Compare
Signed-off-by: ejseqera <esha.joshi@seqera.io>
071a3ef
to
23da7ea
Compare
This PR implements the feature request from #5950 to add support for configuring network tags when running Nextflow pipelines on Google Batch. Network tags can be specified in the Nextflow config file and will be applied to the Batch job's allocation policy.
Changes:
networkTags
property toBatchConfig
GoogleBatchTaskHandler
to apply tags to theAllocationPolicy
Example config: