Skip to content

fix lambda deployment #714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 3, 2022

Conversation

rashadmoarref
Copy link
Contributor

This PR fixes issue #711 by adding a waiter on function_updated.

@bokats
Copy link

bokats commented Jan 21, 2022

@rashadmoarref Any idea when this will be merged. I am seeing the same issue.

@rashadmoarref
Copy link
Contributor Author

@bokats I opened the PR, but would leave it for the repo maintainer to review and merge. @nficano, would you be able to review and merge this PR? I'm internally working with the fork I created and this PR resolves the deployment issue. Please let me know if you need additional information :)

@gdvalderrama
Copy link

gdvalderrama commented Mar 1, 2022

Just tried these changes to get it to work.
Only needed the waiter, I guess the click version change is just a plus.

UPDATE: I'm actually using this PR from my dependencies meanwhile, in my requirements file:
git+https://github.com/nficano/python-lambda.git@refs/pull/714/head

Copy link

@gdvalderrama gdvalderrama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried locally with docker with success

corrected typo in comment
@Lowess
Copy link

Lowess commented Mar 15, 2022

Can we please get this ticket merged as it seems like everyone need to shift to this branch to get the project working ?

@rashadmoarref
Copy link
Contributor Author

@nficano Could we move ahead with merging this PR? It will save a lot of time from other people coming up with the same solution, such as #716

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants