Skip to content

Indent callout in list #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2025
Merged

Indent callout in list #244

merged 1 commit into from
May 2, 2025

Conversation

lamATnginx
Copy link
Collaborator

Proposed changes

Closes https://github.com/nginxinc/docs-platform/issues/465

Before:
Screenshot 2025-05-01 at 10 35 37 AM

After:
Screenshot 2025-05-01 at 10 35 26 AM

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md and CHANGELOG.md)

@lamATnginx lamATnginx added the bug Something isn't working label May 1, 2025
@lamATnginx lamATnginx self-assigned this May 1, 2025
@lamATnginx lamATnginx requested a review from a team as a code owner May 1, 2025 17:36
Copy link
Contributor

@danielledeleo danielledeleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is an option, but even in your example there's non-callout text that's part of a bullet list that no longer has a bullet associated with it.

What I'd like to see instead is just what oldframe does. Let's just indent callouts inside of lists.

Screenshot 2025-05-01 at 6 38 25 PM

Now, in a perfect world, I think this callout should be either outside of the list or off to the side. It's awkward even in OF.

@lamATnginx
Copy link
Collaborator Author

Updated after:

Screenshot 2025-05-01 at 3 46 58 PM

@lamATnginx lamATnginx force-pushed the fix/callout-bullet branch from a79d4f7 to 781471f Compare May 1, 2025 22:49
@lamATnginx lamATnginx changed the title Remove gracefully bullet from call-out in list Indent callout in list May 1, 2025
@lamATnginx lamATnginx requested a review from danielledeleo May 1, 2025 22:51
@nginx-jack nginx-jack merged commit 1338f38 into main May 2, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants