Skip to content

ci: downgrade libc to 0.2.171 in CI for hurd #2632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 21, 2025

Conversation

SteveLauC
Copy link
Member

@SteveLauC SteveLauC commented Apr 16, 2025

What does this PR do

  1. In our CI, pin libc to 0.2.171 on hurd to work around this issue: 0.2.172 is broken on hurd rust-lang/libc#4421
  2. Bump CI runner images, Ubuntu-20.04 is deprecated.
  3. Ignore test test_prctl::test_set_vma_anon_name under QEMU due to ptctl(PR_SET_VMA, PR_SET_VMA_ANON_NAME, addr, len, invalid_name) returns EFAULT rather than EINVAL under QEMU #2418
  4. Allow clippy::unwrap_or_default as IMHO it is overly opinionated

Checklist:

  • I have read CONTRIBUTING.md
  • I have written necessary tests and rustdoc comments
  • A change log has been added if this PR modifies nix's API

@SteveLauC SteveLauC changed the title try reproducing the CI error chore: pin libc to 0.2.171 & bump CI image Apr 16, 2025
@SteveLauC SteveLauC mentioned this pull request Apr 16, 2025
3 tasks
@Berrysoft
Copy link
Contributor

Berrysoft commented Apr 16, 2025

Please don't do that, because cygwin needs 0.2.172

EDIT: how about just to pin libc to 0.2.171 on hurd?

@SteveLauC
Copy link
Member Author

how about just to pin libc to 0.2.171 on hurd?

Sounds good, I will do it

Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of pinning libc in Cargo.toml, I think you should do it just in the CI configuration . On the hurd target, do an extra step of cargo update -p libc --precise 0.2.171. That way we won't be limiting the libc version that our consumers can use.

@SteveLauC SteveLauC marked this pull request as ready for review April 21, 2025 03:39
@SteveLauC SteveLauC added this pull request to the merge queue Apr 21, 2025
@SteveLauC SteveLauC changed the title chore: pin libc to 0.2.171 & bump CI image ci: downgrade libc to 0.2.171 in CI for hurd Apr 21, 2025
Merged via the queue into nix-rust:master with commit eba0f41 Apr 21, 2025
40 checks passed
@SteveLauC SteveLauC deleted the ci/error branch April 21, 2025 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants