Skip to content

Logout using OIDC credentials instead of cookies #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

RubenVerborgh
Copy link
Contributor

Closes #69.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.6%) to 61.593% when pulling 7fb5457 on feature/logout-oidc into eb36d24 on master.

@dmitrizagidulin
Copy link
Contributor

(I think the idea is that you want to redirect the user (either the main page or a popup window) to the logour request’s url. that way, it also lets the browser clear the cookie to the IdP. otherwise, it’s still a third-party js request, which solid server should ignore. this also sets up the workflow for the next feature (a confirmation page saying, ok you’re logging out of the RP, do you also want to log out of IdP?).)

@RubenVerborgh
Copy link
Contributor Author

I think the idea is that you want to redirect the user (either the main page or a popup window) to the logour request’s url.

But you recommended a POST request in nodeSolidServer/node-solid-server#835 (comment) ?

otherwise, it’s still a third-party js request, which solid server should ignore.

But it is signed?

@dmitrizagidulin
Copy link
Contributor

Yeah, I did recommend a POST, I forgot about the redirection at that time :)

But is it signed?

Yeah, the request is signed (in the sense of, it’s carrying a signed id token credential). But I suspect without redirection, you’re gonna have a tough time clearing the cookie. (plus there’s no way to prompt the user if they want to also log out of idp and rp)

Base automatically changed from master to main February 24, 2021 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants