Skip to content

build: fix missing files warning #57870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 19, 2025
Merged

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Apr 14, 2025

This commit fixes the following warning:

Warning: Missing input files:
C:\Users\lpinca\node\tools\v8_gypfiles\..\..\deps\v8\third_party\abseil-cpp\absl\strings\internal\has_absl_stringify.h
C:\Users\lpinca\node\deps\ncrypto\dh-primes.h

bd3c25cf31282f101196 removed '<(ABSEIL_ROOT)/absl/strings/has_absl_stringify.h' instead of '<(ABSEIL_ROOT)/absl/strings/internal/has_absl_stringify.h'

Refs: 5ab3140dfbf0dfa33a66
Refs: b9b4cb7731168671d8f4

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto
  • @nodejs/gyp
  • @nodejs/security-wg
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency. labels Apr 14, 2025
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 14, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 14, 2025
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

This commit fixes the following warning:

    Warning: Missing input files:
    C:\Users\lpinca\node\tools\v8_gypfiles\..\..\deps\v8\third_party\abseil-cpp\absl\strings\internal\has_absl_stringify.h
    C:\Users\lpinca\node\deps\ncrypto\dh-primes.h

nodejs@bd3c25cf31282f101196 removed
`'<(ABSEIL_ROOT)/absl/strings/has_absl_stringify.h'` instead of
`'<(ABSEIL_ROOT)/absl/strings/internal/has_absl_stringify.h'`

Refs: nodejs@5ab3140dfbf0dfa33a66
Refs: nodejs@b9b4cb7731168671d8f4
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 15, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 15, 2025
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 19, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 19, 2025
@nodejs-github-bot nodejs-github-bot merged commit 2cff98c into nodejs:main Apr 19, 2025
57 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 2cff98c

@lpinca lpinca deleted the fix/warning branch April 19, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants