-
-
Notifications
You must be signed in to change notification settings - Fork 31.4k
crypto: forbid passing Float16Array
to getRandomValues()
#57880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crypto: forbid passing Float16Array
to getRandomValues()
#57880
Conversation
Review requested:
|
Can you add a test? |
I believe this is already covered by wpt (although the relevant test is temporarily disabled exactly because of no |
Adding the dont-land label as I think there's no point to have this check on release lines that do not have |
It would probably make sense to enable the test in this PR, passing the V8 flag to expose |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #57880 +/- ##
==========================================
- Coverage 90.23% 90.23% -0.01%
==========================================
Files 630 630
Lines 185688 185788 +100
Branches 36405 36416 +11
==========================================
+ Hits 167559 167648 +89
- Misses 11000 11007 +7
- Partials 7129 7133 +4
🚀 New features to boost your workflow:
|
Landed in c11c7be |
Depends on: #57879