-
-
Notifications
You must be signed in to change notification settings - Fork 31.4k
process: disable building execve on IBM i #57883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The `execve` syscall does exist on IBM i but it has caveats that make it not usable in Node.js context. These changes disable building with `execve` like Windows does.
CC @nodejs/platform-ibmi |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #57883 +/- ##
==========================================
+ Coverage 90.23% 90.24% +0.01%
==========================================
Files 630 630
Lines 185688 185687 -1
Branches 36405 36410 +5
==========================================
+ Hits 167559 167581 +22
- Misses 11000 11005 +5
+ Partials 7129 7101 -28
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I ran test build on IBM i and looks like this test failed I think I need to add to this condition for IBM i here: node/lib/internal/process/per_thread.js Lines 289 to 291 in 91d8a52
|
After adding ed3865c build is passing again https://ci.nodejs.org/job/node-test-commit-ibmi/nodes=ibmi74-ppc64/1899/console |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM again after update
Landed in 963b24e |
The
execve
syscall does exist on IBM i butit has caveats that make it not usable in Node.js context.
These changes disable building with
execve
like Windows does.Fixes #57882