worker: add worker.getHeapStatistics()

[mcollina]

Adds worker.getHeapStatistics() so that the heap usage of the worker could be observer from the parent thread.

[mcollina]

In node_v8.cc, the same is exposed via

node/src/node_v8.cc

Lines 57 to 71 in 2204587

	#define HEAP_STATISTICS_PROPERTIES(V) \
	V(0, total_heap_size, kTotalHeapSizeIndex) \
	V(1, total_heap_size_executable, kTotalHeapSizeExecutableIndex) \
	V(2, total_physical_size, kTotalPhysicalSizeIndex) \
	V(3, total_available_size, kTotalAvailableSize) \
	V(4, used_heap_size, kUsedHeapSizeIndex) \
	V(5, heap_size_limit, kHeapSizeLimitIndex) \
	V(6, malloced_memory, kMallocedMemoryIndex) \
	V(7, peak_malloced_memory, kPeakMallocedMemoryIndex) \
	V(8, does_zap_garbage, kDoesZapGarbageIndex) \
	V(9, number_of_native_contexts, kNumberOfNativeContextsIndex) \
	V(10, number_of_detached_contexts, kNumberOfDetachedContextsIndex) \
	V(11, total_global_handles_size, kTotalGlobalHandlesSizeIndex) \
	V(12, used_global_handles_size, kUsedGlobalHandlesSizeIndex) \
	V(13, external_memory, kExternalMemoryIndex)

. Do you want me to use that approach here?

[anonrig]

If you use the object constructor that takes an array of keys and array of values, it will be faster

[mcollina]

Have you got an example I can copy from?

[anonrig]

Src/node_v8.cc line 350

[Qard]

Only thing that might be of concern would be that placing this on the worker object loses the isolation as v8-specific that the one in the v8 module has. An alternative implementation could be something like v8.getWorkerHeapStatistics(worker) to keep it in that v8-specific segment of the API, if that's something we care about. I would not block on this, but I figured it worth bringing up.

Other than that, agreed that the array form object construction would be better.

[codecov]

Codecov Report

Attention: Patch coverage is 90.21739% with 9 lines in your changes missing coverage. Please review.

Project coverage is 90.23%. Comparing base (2204587) to head (df57fa3).
Report is 15 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_worker.cc	88.88%	5 Missing and 4 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #57888      +/-   ##
==========================================
- Coverage   90.24%   90.23%   -0.01%     
==========================================
  Files         630      630              
  Lines      185688   185783      +95     
  Branches    36403    36414      +11     
==========================================
+ Hits       167569   167647      +78     
- Misses      10997    11009      +12     
- Partials     7122     7127       +5     

Files with missing lines	Coverage Δ
lib/internal/worker.js	99.82% <100.00%> (+<0.01%)	⬆️
src/node_worker.h	90.90% <ø> (ø)
src/node_worker.cc	84.45% <88.88%> (+0.72%)	⬆️

... and 27 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[legendecas]

Only thing that might be of concern would be that placing this on the worker object loses the isolation as v8-specific that the one in the v8 module has.

There is a precedent of Worker.getHeapSnapshot, coresponding to v8.getHeapSnapshot.

[mcollina]

Only thing that might be of concern would be that placing this on the worker object loses the isolation as v8-specific that the one in the v8 module has.

There is also the event loop utilization monitoring that can be done from the outside, too.

[mcollina]

@joyeecheung @legendecas PTAL.

[mcollina]

@Qard @RaisinTen PTAL

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/66299/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/66301/

[mcollina]

Sorry, I need another LGTM due to an unexpected test failure on ARM.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/66313/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/66326/

[nodejs-github-bot]

Landed in 33d8e03