-
-
Notifications
You must be signed in to change notification settings - Fork 31.4k
2025-04-22, Version 20.19.1 'Iron' (LTS) #57896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The backported patches already include the commit that disables the warning unless `--trace-require-module` is explicitly used. Correct the changelog to match the status. PR-URL: #57529 Fixes: #57517 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #57792 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #57442 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Fixes: #57636 Co-authored-by: Robert Nagy <ronagy@icloud.com> PR-URL: #57640 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
The output of the `s_client` command invoked by the test has changed in the OpenSSL 3.5.0 version of `s_client`. Update the test so that it works with both the old and new output -- the `s_client` binary being run may not be at the exact same version of OpenSSL as used by Node.js so the updated test allows either output. PR-URL: #57477 Refs: openssl/openssl#26734 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Xuguang Mei <meixuguang@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Notable changes: PR-URL: #57896
Review requested:
|
@UlisesGascon will be the one promoting it. I will change the changelog name. |
b25099a
to
7d25553
Compare
7d25553
to
109a136
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Refs: https://github.blog/changelog/2025-03-20-notification-of-upcoming-breaking-changes-in-github-actions/ Refs: mozilla/sccache#2339 PR-URL: #57573 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Bumps [Mozilla-Actions/sccache-action](https://github.com/mozilla-actions/sccache-action) from 0.0.8 to 0.0.9. - [Release notes](https://github.com/mozilla-actions/sccache-action/releases) - [Commits](Mozilla-Actions/sccache-action@65101d4...7d986dd) --- updated-dependencies: - dependency-name: Mozilla-Actions/sccache-action dependency-version: 0.0.9 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> PR-URL: #57720 Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
109a136
to
e7a6507
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the great work @RafaelGSS!
I will start with the promotion tomorrow in my morning (in aprox. 12h). |
I am starting with the promotion now 🥳 📦 CI-Release: ci-release.nodejs.org/job/iojs+release/10915 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
2025-04-22, Version 20.19.1 'Iron' (LTS), @UlisesGascon prepared by @RafaelGSS
Notable Changes
d5e73ce0f8
] - deps: update undici to 6.21.2 (Matteo Collina) #57442e4a6323ab2
] - deps: update c-ares to v1.34.5 (Node.js GitHub Bot) #57792Commits
d5e73ce0f8
] - deps: update undici to 6.21.2 (Matteo Collina) #57442e4a6323ab2
] - deps: update c-ares to v1.34.5 (Node.js GitHub Bot) #57792b2b9eb36af
] - dns: restore dns query cache ttl (Ethan Arrowood) #5764007a99a5c0b
] - doc: correct status of require(esm) warning in v20 changelog (Joyee Cheung) #57529d45517ccbf
] - meta: bump Mozilla-Actions/sccache-action from 0.0.8 to 0.0.9 (dependabot[bot]) #57720fa93bb2633
] - test: update parallel/test-tls-dhe for OpenSSL 3.5 (Richard Lau) #5747729c032403c
] - tools: update sccache to support GH cache changes (Michaël Zasso) #57573