buffer: avoid creating unnecessary environment

[anonrig]

We don't have to deference the args pointer to create an environment variable while having access to isolate using args.GetIsolate()

[juanarbol]

sgtm

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/66485/

[jasnell]

To be fair, the changed code is not creating an Environment unnecessarily, it is simply dereferencing a pointer.

[anonrig]

To be fair, the changed code is not creating an Environment unnecessarily, it is simply dereferencing a pointer.

Ah true. Thanks. Still seems like an unnecessary operation that we do in almost all places.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.20%. Comparing base (e0cf8ae) to head (4df7266).
Report is 7 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #58053      +/-   ##
==========================================
+ Coverage   90.18%   90.20%   +0.01%     
==========================================
  Files         630      630              
  Lines      186393   186393              
  Branches    36595    36594       -1     
==========================================
+ Hits       168103   168140      +37     
+ Misses      11090    11081       -9     
+ Partials     7200     7172      -28     

Files with missing lines	Coverage Δ
src/node_buffer.cc	67.51% <100.00%> (ø)

... and 24 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/66488/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/66491/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/66499/