src: fix internalModuleStat v8 fast path #58054
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
lib / src
anonrig
force-pushed
the
yagiz/internal-module-stat
branch
from
b563e9e to
aa493c2
Compare
jasnell
approved these changes
Apr 27, 2025
anonrig
added
author ready
github-actions
bot
removed
the
request-ci
ronag
approved these changes
Apr 27, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #58054 +/- ##
=======================================
Coverage 90.18% 90.19%
=======================================
Files 630 630
Lines 186393 186392 -1
Branches 36595 36592 -3
=======================================
+ Hits 168103 168119 +16
+ Misses 11090 11089 -1
+ Partials 7200 7184 -16
🚀 New features to boost your workflow:
|
anonrig
added
the
commit-queue
RafaelGSS
reviewed
Apr 29, 2025
nodejs-github-bot
removed
the
commit-queue
|
Landed in 5ed1bcb |
nodejs-github-bot
added
the
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/58054 ✔ Done loading data for nodejs/node/pull/58054 ----------------------------------- PR info ------------------------------------ Title src: fix internalModuleStat v8 fast path (#58054) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch anonrig:yagiz/internal-module-stat -> nodejs:main Labels lib / src, author ready, needs-ci Commits 1 - src: fix internalModuleStat v8 fast path Committers 1 - Yagiz Nizipli <yagiz@nizipli.com> PR-URL: https://github.com/nodejs/node/pull/58054 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/58054 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 27 Apr 2025 17:45:21 GMT ✔ Approvals: 2 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/58054#pullrequestreview-2797706038 ✔ - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/58054#pullrequestreview-2797709654 ⚠ This PR was merged on Tue, 29 Apr 2025 17:53:13 GMT ✔ Last GitHub CI successful ℹ Last Full PR CI on 2025-04-27T18:10:22Z: https://ci.nodejs.org/job/node-test-pull-request/66486/ - Querying data for job/node-test-pull-request/66486/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/14777283946 |
RafaelGSS
pushed a commit
that referenced
this pull request
May 1, 2025
PR-URL: #58054 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com>
RafaelGSS
pushed a commit
that referenced
this pull request
May 2, 2025
PR-URL: #58054 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v8 fast path was not triggering before this. I've updated the implementation and added proper test for it.
cc @nodejs/cpp-reviewers @nodejs/performance