Add process groups to unix backends #802
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talex5
approved these changes
May 22, 2025
|
|
||
| static void action_setpgid(int errors, value v_config) { | ||
| #ifdef _WIN32 | ||
| eio_unix_fork_error(errors, "set_cloexec", "Unsupported operation on windows"); |
There was a problem hiding this comment.
Suggested change
| eio_unix_fork_error(errors, "set_cloexec", "Unsupported operation on windows"); | |
| eio_unix_fork_error(errors, "setpgid", "Unsupported operation on windows"); | |
| _exit(1); |
Perhaps eio_unix_fork_error should call _exit itself. Looks like everything that uses it either does that or is wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is, I hope, most of the plumbing for #595. It remains to decide on how best to expose this in
Eio.Processif at all.Also if anyone has a good, reproducible test for this, that would be good too!