Skip to content

prevent default when we are in edit mode #4723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master-mysterious-egg
Choose a base branch
from
+1 −3
Open

prevent default when we are in edit mode #4723

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions addons/website/static/src/client_actions/website_preview/website_builder_action.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,16 +275,14 @@ export class WebsiteBuilder extends Component {
// Forward clicks to close backend client action's navbar
// dropdowns.
this.websiteContent.el.dispatchEvent(new MouseEvent("click", ev));
/* TODO ?
} else {
// When in edit mode, prevent the default behaviours of clicks
// as to avoid DOM changes not handled by the editor.
// (Such as clicking on a link that triggers navigating to
// another page.)
if (!ev.target.closest("#oe_manipulators")) {
if (!ev.target.closest("body.editor_enable")){
ev.preventDefault();
}
*/
}
const linkEl = ev.target.closest("[href]");
if (!linkEl) {
Expand Down