[FW][FIX] coding_guidelines: Add comment to indicate ASCII-based ordering #12962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@hamo-odoo cherrypicking of pull request #12951 failed. stdout: Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?). In the former case, you may want to edit this PR message as well. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
hamo-odoo
force-pushed
the
saas-18.2-16.0-coding-guidelines-ascii-comment-fix-hamo-430549-fw
branch
from
29e6b9f to
cfc755d
Compare
hamo-odoo
approved these changes
Apr 21, 2025
|
@hamo-odoo staging failed: ci/runbot on 9d51fabb55e2fdd4f500606f59a76d14c90fa6b0 (view more at https://runbot.odoo.com/runbot/build/78795641) |
|
@robodoo retry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the fix - 92c7099 Adding a comment to explicitly indicate that the import is ordered alphabetically based on ASCII values.
Forward-Port-Of: #12951