[SYCLomaitc] Add the IPC memory APIs migration to level zero APIs. #2694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chen, Sheng S <sheng.s.chen@intel.com>
tomflinda
pushed a commit
to tomflinda/SYCLomatic
that referenced
this pull request
Mar 10, 2025
…bool-refactoring Revert "[L0] Refactoring of boolean event parameters"
Signed-off-by: Chen, Sheng S <sheng.s.chen@intel.com>
ShengchenJ
changed the title
ShengchenJ
changed the title
zhiweij1
reviewed
Apr 24, 2025
zhiweij1
reviewed
Apr 24, 2025
tomflinda
reviewed
Apr 24, 2025
tomflinda
reviewed
Apr 24, 2025
tomflinda
reviewed
Apr 24, 2025
Signed-off-by: Chen, Sheng S <sheng.s.chen@intel.com>
zhiweij1
approved these changes
Apr 24, 2025
Signed-off-by: Chen, Sheng S <sheng.s.chen@intel.com>
|
|
||
| /// Extracts native Level Zero context handle from SYCL context. | ||
| /// \param [in] context SYCL context object | ||
| /// \returns Native Level Zero context handle |
There was a problem hiding this comment.
let's simplify the helper function by removing unnecessary ones.
| /// \param [in] phipc Source IPC handle structure | ||
| /// \returns Local process file descriptor | ||
| template <class T> int get_cur_pid(T phipc) { | ||
| int pidfd = syscall(SYS_pidfd_open, phipc.pid, 0); |
There was a problem hiding this comment.
please call pidfd_open directly?
| /// Cross-process file descriptor translator. | ||
| /// \param [in] phipc Source IPC handle structure | ||
| /// \returns Local process file descriptor | ||
| template <class T> int get_cur_pid(T phipc) { |
There was a problem hiding this comment.
the value returned is fd, not pid.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.