Skip to content

Feat: Add support for pattern properties #2288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

hontas
Copy link

@hontas hontas commented May 5, 2025

Changes

Add support for patternProperties in addition to additionalProperties (#754).
Building on the work of @gzm0 in 1901 by adding tests

Ran the command pnpm run update:examples which created 129 new files and updated 69, none of which seemed related to this change. Let me know if you wan't me to do it anyways.

How to Review

Refer to comments in original PR 1901
Validate tests are satisfactory

Checklist

  • Unit tests updated
  • docs/ updated (if necessary)
  • pnpm run update:examples run (only applicable for openapi-typescript)

@hontas hontas requested a review from a team as a code owner May 5, 2025 08:21
@hontas hontas requested a review from kerwanp May 5, 2025 08:21
Copy link

netlify bot commented May 5, 2025

👷 Deploy request for openapi-ts pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit b299279

Copy link

changeset-bot bot commented May 5, 2025

🦋 Changeset detected

Latest commit: b299279

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
openapi-typescript Minor
swr-openapi Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@hontas hontas force-pushed the pattern-properties branch from f508c21 to b299279 Compare May 5, 2025 08:34
@gzm0
Copy link
Contributor

gzm0 commented May 5, 2025

@kerwanp LMK if you'd like to hand-off review to me here.
@hontas TY so much for taking this over!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants