-
Notifications
You must be signed in to change notification settings - Fork 6
[FEATURE] Redesigned Settings-Screen and Workflow #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release_9
Are you sure you want to change the base?
[FEATURE] Redesigned Settings-Screen and Workflow #38
Conversation
The initial issue described here (#35 (comment)) appears with this PR. |
EDIT (16.5.): Fixed and approved. When choosing an Opencast video for the first time, is the actual width of the video taken as "Maximale Breite" or the configured "Default width" (see config of plugin)? In my tests, it seems like the configured "Default width" gets shown. |
When an admin does "Ersetzen" an already inserted Opencast video, the success message "Video successfully selected." (or "... succesfully exchanged.") is missing. |
Option "Vorschaubild verlinkt auf Video" does not work. When activated, a click on the shown thumbnail has no effect. |
EDIT (16.5.): Fixed and approved. Inserted videos sometimes show an error. I can not recognize any rule here. But here's what I observe:
I will talk to @snoesberger if this could be an issue with our test environment. ![]() ![]() ![]() ![]() |
I've checked our Opencast test environment and everything is fine, I can't see any errors in the Opencast logs either. So I assume the problem is on the plugin side. |
@dagraf I try to write your findings in a list with checkboxes, so we have a better overview. I will update this comment with feedback and update the checkboxes for resolved issues.
The ReviewApp is updated with the checked issues: http://ocpc-pr-38.opencast.k8s.sr.solutions/ |
@dagraf The ReviewApp is updated with the checked issues: http://ocpc-pr-38.opencast.k8s.sr.solutions/ |
This branch contains the completely revised UI for the PC plugin in the settings view and also in the rendering of the content. See screenshot.
To discuss:
Do we need the aspect ratio? I have now implemented it so that you can adopt the aspect ratio of the publication by default. However, if desired, you can overwrite this.
This branch requires the following branch of the main plugin: opencast-ilias/OpenCast#430