Skip to content

[FEATURE] Redesigned Settings-Screen and Workflow #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: release_9
Choose a base branch
from

Conversation

chfsx
Copy link
Collaborator

@chfsx chfsx commented Apr 4, 2025

This branch contains the completely revised UI for the PC plugin in the settings view and also in the rendering of the content. See screenshot.

image

To discuss:
Do we need the aspect ratio? I have now implemented it so that you can adopt the aspect ratio of the publication by default. However, if desired, you can overwrite this.

This branch requires the following branch of the main plugin: opencast-ilias/OpenCast#430

@chfsx chfsx requested a review from Copilot April 4, 2025 15:12
Copilot

This comment was marked as resolved.

@chfsx
Copy link
Collaborator Author

chfsx commented Apr 4, 2025

This is what I like about such refactorings:
image

@dagraf
Copy link

dagraf commented Apr 22, 2025

The initial issue described here (#35 (comment)) appears with this PR.

@dagraf
Copy link

dagraf commented Apr 22, 2025

Please write title "Insert existing video from Opencast" NOT bold (same for all other titles, such as "Aktuell ausgewähltes Video" and "Eigenschaften") and remove subtitle "Events" (see screenshot).

Bildschirmfoto 2025-04-22 um 21 45 57

@dagraf
Copy link

dagraf commented Apr 22, 2025

EDIT (16.5.): Fixed and approved.

When setting "Seitenverhältnis" is set to 16:9, the inserted video is not displayed in 16:9 format (see screenshots). When it is set to "As in publication" and the format of the video is 16:9, the video gets correctly displayed in 16:9 format.

Bildschirmfoto 2025-04-22 um 21 55 04 Bildschirmfoto 2025-04-22 um 21 55 31

@dagraf
Copy link

dagraf commented Apr 22, 2025

EDIT (16.5.2025): Fixed and approved.

A lot of English translations are missing (see screenshot for example).

Bildschirmfoto 2025-04-22 um 22 00 17

@dagraf
Copy link

dagraf commented Apr 22, 2025

Explanation of option "Seitenverhältnis" is not as specified (see screenshot of mockup).

Bildschirmfoto 2025-04-22 um 22 01 15

@dagraf
Copy link

dagraf commented Apr 22, 2025

EDIT (16.5.): Fixed and approved.

When choosing an Opencast video for the first time, is the actual width of the video taken as "Maximale Breite" or the configured "Default width" (see config of plugin)? In my tests, it seems like the configured "Default width" gets shown.

@dagraf
Copy link

dagraf commented Apr 22, 2025

Specified "Hover-Over Info" ("Opencast-Video") is missing (see screenshot of mockup).

Bildschirmfoto 2025-04-22 um 22 08 26

@dagraf
Copy link

dagraf commented Apr 22, 2025

Correct English version of "Bestehendes Video aus Opencast auswählen" (see screenshot: "Insert existing video from Opencast") to "Select existing video from Opencast". While doing so, please add missing English translations of "Auswählen" (see screenshot, English: "Select").

Bildschirmfoto 2025-04-22 um 22 13 04

@dagraf
Copy link

dagraf commented Apr 22, 2025

When an admin does "Ersetzen" an already inserted Opencast video, the success message "Video successfully selected." (or "... succesfully exchanged.") is missing.

@dagraf
Copy link

dagraf commented Apr 22, 2025

Ordering issues:

  • Ordering Z-A for "Title" does not work correctly. A-Z works as expected.
  • Orderin for "Series" does not work at all. When hitting on the the row title "Series" a empty table is shown (see screenshot).
Bildschirmfoto 2025-04-22 um 22 21 28

@dagraf
Copy link

dagraf commented Apr 22, 2025

Option "Vorschaubild verlinkt auf Video" does not work. When activated, a click on the shown thumbnail has no effect.

@dagraf
Copy link

dagraf commented Apr 22, 2025

EDIT (16.5.): Fixed and approved.

Inserted videos sometimes show an error. I can not recognize any rule here. But here's what I observe:

  • I have inserted 5 Opeoncast videos.
  • When I reload my browser, always different videos show issues (except the one "Vorschaubild verlinkt auf Video" at the very top). See screenshots.
  • There seem to be 2 different type of errors: (i) SQLSTATE[23000]: Integrity constraint violation: ...; (ii) Trying to access array offset on value of type null.

I will talk to @snoesberger if this could be an issue with our test environment.

Bildschirmfoto 2025-04-22 um 22 27 44 Bildschirmfoto 2025-04-22 um 22 27 52 Bildschirmfoto 2025-04-22 um 22 28 03 Bildschirmfoto 2025-04-22 um 22 28 15

@snoesberger
Copy link

Inserted videos sometimes show an error. I can not recognize any rule here. But here's what I observe:

* I have inserted 5 Opeoncast videos.

* When I reload my browser, always different videos show issues (except the one "Vorschaubild verlinkt auf Video" at the very top). See screenshots.

* There seem to be 2 different type of errors: (i) SQLSTATE[23000]: Integrity constraint violation: ...; (ii) Trying to access array offset on value of type null.

I will talk to @snoesberger if this could be an issue with our test environment.

I've checked our Opencast test environment and everything is fine, I can't see any errors in the Opencast logs either. So I assume the problem is on the plugin side.

@chfsx
Copy link
Collaborator Author

chfsx commented May 15, 2025

@dagraf I try to write your findings in a list with checkboxes, so we have a better overview. I will update this comment with feedback and update the checkboxes for resolved issues.

  • Please write title "Insert existing video from Opencast" NOT bold (same for all other titles, such as "Aktuell ausgewähltes Video" and "Eigenschaften") and remove subtitle "Events" (see screenshot).

We do not influence anything ourselves (e.g. bold etc.), that is how the UI components look and we cannot/should not influence that. the subheading, for example, is required by the table, so we have to write something in there. of course, we could also insert an empty string ‘’, but that actually contradicts the rules of the UI components.

  • When setting "Seitenverhältnis" is set to 16:9, the inserted video is not displayed in 16:9 format (see screenshots). When it is set to "As in publication" and the format of the video is 16:9, the video gets correctly displayed in 16:9 format. > Fix confirmed by @dagraf

I managed to fix that, will be part of the next deployment (I will inform you as soon as the ReviewApp is updated)

  • A lot of English translations are missing (see screenshot for example). > Fix confirmed by @dagraf

I added several missing translations now

  • Explanation of option "Seitenverhältnis" is not as specified (see screenshot of mockup).

@dagraf in the mockup the option is labled/described with "Seitenverhältnis des ausgewählten Videos. Wird so in die Seite eingefügt.". Is there another ver4sion of the mockups?

  • When choosing an Opencast video for the first time, is the actual width of the video taken as "Maximale Breite" or the configured "Default width" (see config of plugin)? In my tests, it seems like the configured "Default width" gets shown. > Fix confirmed by @dagraf

This is fixed now and the width of the original publication is used if possible

  • Specified "Hover-Over Info" ("Opencast-Video") is missing (see screenshot of mockup).

I haven't found a way for a plugin to influence this. In my opinion, this is a bug in the core that prevents the names of the plugins from being displayed here. I have also tried this with other PageComponentPlugins, but none of them display anything here.

  • Correct English version of "Bestehendes Video aus Opencast auswählen" (see screenshot: "Insert existing video from Opencast") to "Select existing video from Opencast". While doing so, please add missing English translations of "Auswählen" (see screenshot, English: "Select").

I updated the english language file

  • When an admin does "Ersetzen" an already inserted Opencast video, the success message "Video successfully selected." (or "... succesfully exchanged.") is missing.
  • Ordering Z-A for "Title" does not work correctly. A-Z works as expected.
  • Orderin for "Series" does not work at all. When hitting on the the row title "Series" a empty table is shown (see screenshot).
  • Option "Vorschaubild verlinkt auf Video" does not work. When activated, a click on the shown thumbnail has no effect.
  • Inserted videos sometimes show an error. I can not recognize any rule here. > Fix confirmed by @dagraf

This should be fixed now

The ReviewApp is updated with the checked issues: http://ocpc-pr-38.opencast.k8s.sr.solutions/

@chfsx
Copy link
Collaborator Author

chfsx commented May 15, 2025

@dagraf The ReviewApp is updated with the checked issues: http://ocpc-pr-38.opencast.k8s.sr.solutions/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Testing
Development

Successfully merging this pull request may close these issues.

3 participants