Skip to content

ART-12521: update go mod dependency for konflux #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

ashwindasr
Copy link

@ashwindasr ashwindasr commented Apr 4, 2025

Image build was failing on Konflux due to missing go mod dependencies.

2025-04-04 17:29:31,671 INFO Vendoring the gomod dependencies
2025-04-04 17:29:38,678 ERROR vendor/modules.txt changed after vendoring:
diff --git a/vendor/modules.txt b/vendor/modules.txt
index dacf5d968..618104d7c 100644
--- a/vendor/modules.txt
+++ b/vendor/modules.txt
@@ -767,7 +767,6 @@ go.opentelemetry.io/proto/otlp/resource/v1
 go.opentelemetry.io/proto/otlp/trace/v1
 # go.uber.org/atomic v1.11.0
 ## explicit; go 1.18
-go.uber.org/atomic
 # go.uber.org/multierr v1.11.0
 ## explicit; go 1.19
 go.uber.org/multierr
2025-04-04 17:29:41,297 ERROR PackageRejected: The content of the vendor directory is not consistent with go.mod. Please check the logs for more details.
Error: PackageRejected: The content of the vendor directory is not consistent with go.mod. Please check the logs for more details.
  Please try running `go mod vendor` and committing the changes.
  Note that you may need to `git add --force` ignored files in the vendor/ dir.
  Docs: https://github.com/containerbuildsystem/cachi2/blob/main/docs/gomod.md#vendoring

Konflux ignores .gitignore files since its a possible security gap. Running go mod vendor on my local produced these changes. Please verify if they are expected to address the above issue.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 4, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 4, 2025

@ashwindasr: This pull request references ART-12521 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Image build was failing on Konflux due to missing go mod dependencies.

2025-04-04 17:29:31,671 INFO Vendoring the gomod dependencies
2025-04-04 17:29:38,678 ERROR vendor/modules.txt changed after vendoring:
diff --git a/vendor/modules.txt b/vendor/modules.txt
index dacf5d968..618104d7c 100644
--- a/vendor/modules.txt
+++ b/vendor/modules.txt
@@ -767,7 +767,6 @@ go.opentelemetry.io/proto/otlp/resource/v1
go.opentelemetry.io/proto/otlp/trace/v1
# go.uber.org/atomic v1.11.0
## explicit; go 1.18
-go.uber.org/atomic
# go.uber.org/multierr v1.11.0
## explicit; go 1.19
go.uber.org/multierr
2025-04-04 17:29:41,297 ERROR PackageRejected: The content of the vendor directory is not consistent with go.mod. Please check the logs for more details.
Error: PackageRejected: The content of the vendor directory is not consistent with go.mod. Please check the logs for more details.
 Please try running `go mod vendor` and committing the changes.
 Note that you may need to `git add --force` ignored files in the vendor/ dir.
 Docs: https://github.com/containerbuildsystem/cachi2/blob/main/docs/gomod.md#vendoring

Konflux ignores .gitignore files since its a possible security gap. Running go mod vendor on my local produced these changes. Please verify if they are expected.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 4, 2025

@ashwindasr: This pull request references ART-12521 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Image build was failing on Konflux due to missing go mod dependencies.

2025-04-04 17:29:31,671 INFO Vendoring the gomod dependencies
2025-04-04 17:29:38,678 ERROR vendor/modules.txt changed after vendoring:
diff --git a/vendor/modules.txt b/vendor/modules.txt
index dacf5d968..618104d7c 100644
--- a/vendor/modules.txt
+++ b/vendor/modules.txt
@@ -767,7 +767,6 @@ go.opentelemetry.io/proto/otlp/resource/v1
go.opentelemetry.io/proto/otlp/trace/v1
# go.uber.org/atomic v1.11.0
## explicit; go 1.18
-go.uber.org/atomic
# go.uber.org/multierr v1.11.0
## explicit; go 1.19
go.uber.org/multierr
2025-04-04 17:29:41,297 ERROR PackageRejected: The content of the vendor directory is not consistent with go.mod. Please check the logs for more details.
Error: PackageRejected: The content of the vendor directory is not consistent with go.mod. Please check the logs for more details.
 Please try running `go mod vendor` and committing the changes.
 Note that you may need to `git add --force` ignored files in the vendor/ dir.
 Docs: https://github.com/containerbuildsystem/cachi2/blob/main/docs/gomod.md#vendoring

Konflux ignores .gitignore files since its a possible security gap. Running go mod vendor on my local produced these changes. Please verify if they are expected to address the above issue.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from Moebasim and sayan-biswas April 4, 2025 18:46
Copy link
Contributor

openshift-ci bot commented Apr 4, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ashwindasr
Once this PR has been reviewed and has the lgtm label, please assign sanchezl for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ashwindasr
Copy link
Author

ashwindasr commented Apr 22, 2025

Should fix check enforced in openshift/release#64090

Copy link
Contributor

openshift-ci bot commented Apr 22, 2025

@ashwindasr: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 10e7020 link false /test security
ci/prow/verify-deps 10e7020 link true /test verify-deps

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ashwindasr ashwindasr closed this May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants