Skip to content

[release-4.19] OCPBUGS-55642: Empty proxy variables are causing issues during the build #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 5, 2025
Merged

[release-4.19] OCPBUGS-55642: Empty proxy variables are causing issues during the build #376

merged 2 commits into from
May 5, 2025

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #373

/assign kunalmemane

prabhapa and others added 2 commits May 2, 2025 11:15
@prabhapa
OCPBUGS-54695:Empty proxy variables are causing issues during the bui…
550e9b4 
…ld Problem: Irrespective of default proxy settings these proxy variables are set on build containers. If any defaults are set they reflect those setting ,if not set they are set to null on the build container. Having these null variables are causing problems to some customers as its breaking some required apps on container HTTP_PROXY,http_proxy,HTTPS_PROXY,https_proxy,NO_PROXY,no_proxy Fix: Code changed only to add these proxy variables only if they are defined in defaults and if they are not null.
@kunalmemane
fix: fixed vendor inconsistency failure to pass verify-deps job
a5b3bd2
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 2, 2025
Merged
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-54695 has been cloned as Jira Issue OCPBUGS-55642. Will retitle bug to link to clone.
/retitle [release-4.19] OCPBUGS-55642: Empty proxy variables are causing issues during the build

In response to this:

This is an automated cherry-pick of #373

/assign kunalmemane

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.19] OCPBUGS-54695: Empty proxy variables are causing issues during the build [release-4.19] OCPBUGS-55642: Empty proxy variables are causing issues during the build May 2, 2025
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: An error was encountered updating to the POST state for bug OCPBUGS-55642 on the Jira server at https://issues.redhat.com/. No known errors were detected, please see the full error message for details.

Full error message. No response returned: Post "https://issues.redhat.com/rest/api/2/issue/16870156/transitions": POST https://issues.redhat.com/rest/api/2/issue/16870156/transitions giving up after 5 attempt(s)

Please contact an administrator to resolve this issue, then request a bug refresh with /jira refresh.

In response to this:

This is an automated cherry-pick of #373

/assign kunalmemane

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from divyansh42 and sanchezl May 2, 2025 11:16
@kunalmemane
Copy link
Contributor

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels May 2, 2025
@openshift-ci-robot
Copy link
Contributor

@kunalmemane: This pull request references Jira Issue OCPBUGS-55642, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-54695 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-54695 targets the "4.20.0" version, which is one of the valid target versions: 4.20.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (jitsingh@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kunalmemane
Copy link
Contributor

/test e2e-aws-ovn

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 2, 2025

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security a5b3bd2 link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Moebasim
Copy link

Moebasim commented May 5, 2025

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label May 5, 2025
@Moebasim
Copy link

Moebasim commented May 5, 2025

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 5, 2025
@Moebasim
Copy link

Moebasim commented May 5, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 5, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Moebasim, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 5, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 8be524d into openshift:release-4.19 May 5, 2025
13 of 14 checks passed
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-55642: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-55642 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #373

/assign kunalmemane

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kunalmemane
Copy link
Contributor

/cherry-pick release-4.18

@openshift-cherrypick-robot
Copy link
Author

@kunalmemane: #376 failed to apply on top of branch "release-4.18":

Applying: OCPBUGS-54695:Empty proxy variables are causing issues during the build Problem: Irrespective of default proxy settings these proxy variables are set on build containers. If any defaults are set they reflect those setting ,if not set they are set to null on the build container. Having these null variables are causing problems to some customers as its breaking some required apps on container HTTP_PROXY,http_proxy,HTTPS_PROXY,https_proxy,NO_PROXY,no_proxy Fix: Code changed only to add these proxy variables only if they are defined in defaults and if they are not null.
Applying: fix: fixed vendor inconsistency failure to pass verify-deps job
Using index info to reconstruct a base tree...
M	go.mod
M	go.sum
M	vendor/modules.txt
Falling back to patching base and 3-way merge...
Auto-merging vendor/modules.txt
CONFLICT (content): Merge conflict in vendor/modules.txt
Removing vendor/go.uber.org/atomic/value.go
Removing vendor/go.uber.org/atomic/unsafe_pointer.go
Removing vendor/go.uber.org/atomic/uintptr.go
Removing vendor/go.uber.org/atomic/uint64.go
Removing vendor/go.uber.org/atomic/uint32.go
Removing vendor/go.uber.org/atomic/time_ext.go
Removing vendor/go.uber.org/atomic/time.go
Removing vendor/go.uber.org/atomic/string_ext.go
Removing vendor/go.uber.org/atomic/string.go
Removing vendor/go.uber.org/atomic/pointer_go119.go
Removing vendor/go.uber.org/atomic/pointer_go118_pre119.go
Removing vendor/go.uber.org/atomic/pointer_go118.go
Removing vendor/go.uber.org/atomic/nocmp.go
Removing vendor/go.uber.org/atomic/int64.go
Removing vendor/go.uber.org/atomic/int32.go
Removing vendor/go.uber.org/atomic/gen.go
Removing vendor/go.uber.org/atomic/float64_ext.go
Removing vendor/go.uber.org/atomic/float64.go
Removing vendor/go.uber.org/atomic/float32_ext.go
Removing vendor/go.uber.org/atomic/float32.go
Removing vendor/go.uber.org/atomic/error_ext.go
Removing vendor/go.uber.org/atomic/error.go
Removing vendor/go.uber.org/atomic/duration_ext.go
Removing vendor/go.uber.org/atomic/duration.go
Removing vendor/go.uber.org/atomic/doc.go
Removing vendor/go.uber.org/atomic/bool_ext.go
Removing vendor/go.uber.org/atomic/bool.go
Removing vendor/go.uber.org/atomic/README.md
Removing vendor/go.uber.org/atomic/Makefile
Removing vendor/go.uber.org/atomic/LICENSE.txt
Removing vendor/go.uber.org/atomic/CHANGELOG.md
Removing vendor/go.uber.org/atomic/.gitignore
Removing vendor/go.uber.org/atomic/.codecov.yml
Auto-merging go.sum
CONFLICT (content): Merge conflict in go.sum
Auto-merging go.mod
CONFLICT (content): Merge conflict in go.mod
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0002 fix: fixed vendor inconsistency failure to pass verify-deps job

In response to this:

/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-openshift-controller-manager
This PR has been included in build ose-openshift-controller-manager-container-v4.19.0-202505051011.p0.g8be524d.assembly.stream.el9.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.19.0-0.nightly-2025-05-05-205331

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divyansh42 divyansh42 Awaiting requested review from divyansh42

@sanchezl sanchezl Awaiting requested review from sanchezl

Assignees

@Moebasim Moebasim

@kunalmemane kunalmemane

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@openshift-cherrypick-robot @openshift-ci-robot @kunalmemane @Moebasim @openshift-bot @openshift-merge-robot @prabhapa