Skip to content

chore(ci): Autobump java-sdk on protocol buffer changes #2083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dmihalcik-virtru
Copy link
Member

Proposed Changes

  • Triggers a dispatch event. Since this will require a new secret, I'm going to do a polling variant that checks to see if this needs updating once in a while

Checklist

  • I have added or updated unit tests
  • I have added or updated integration tests (if appropriate)
  • I have added or updated documentation

Testing Instructions

@dmihalcik-virtru dmihalcik-virtru requested review from a team as code owners April 17, 2025 21:04
steps:
- name: Lookup version of protocol/go
id: version
run: |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:1:106: Double quote to prevent globbing and word splitting [shellcheck]

token: ${{ secrets.JAVA_SDK_DISPATCH_PAT }}
repository: opentdf/java-sdk
event-type: update-platform-branch.yaml
client-payload: '{"tag": "protocol/go/v${{ steps.version.PROTO_VERSION }}"}'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [actionlint] reported by reviewdog 🐶
property "proto_version" is not defined in object type {conclusion: string; outcome: string; outputs: {string => string}} [expression]

Copy link
Contributor

Benchmark Statistics

Name № Requests Avg Duration Min Duration Max Duration
publickey 3 0.067 ms 0.035 ms 0.121 ms
rewrap-nanotdf 4905 417.853 ms 71.596 ms 939.137 ms
rewrap-tdf3 5001 434.616 ms 48.398 ms 981.154 ms

Bulk Benchmark Results

Metric Value
Total Decrypts 100
Successful Decrypts 100
Failed Decrypts 0
Total Time 354.675496ms
Throughput 281.95 requests/second

@dmihalcik-virtru dmihalcik-virtru marked this pull request as draft April 18, 2025 14:09
@dmihalcik-virtru
Copy link
Member Author

I'm going to debug the target workflow using manual dispatch for now, and I'll re-enable this for review once it is working & merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant