[GR-27379] Run C extensions marked as rb_ext_ractor_safe()/rb_ext_thread_safe() without the C extension lock (#2136) #3814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
graalvmbot
force-pushed
the
bd/run-ractor-safe-exts-in-parallel
branch
4 times, most recently
from
68286eb to
8e49cf3
Compare
graalvmbot
force-pushed
the
bd/run-ractor-safe-exts-in-parallel
branch
2 times, most recently
from
748261d to
211e9d2
Compare
* Specifically Etc.getgrgid fails the spec in spec/ruby/library/etc/getgrgid_spec.rb
…without the C extension lock * Fixes #2136. * Rename *c_mutex* methods to *cext_lock* for consistency and clarity.
Linter warning ``` $ jt check_abi These files have changed and might have affected the ABI: lib/cext/include/ruby/internal/intern/load.h src/main/c/cext/ractor.c src/main/c/cext/truffleruby.c Check the diff of this PR, and: * if ABI has changed, then increment lib/cext/include/truffleruby/truffleruby-abi-version.h * if ABI has not changed, then increment lib/cext/ABI_check.txt ```
graalvmbot
force-pushed
the
bd/run-ractor-safe-exts-in-parallel
branch
from
883c48e to
3f59a2f
Compare
* No need to check CEXT_LOCK since useCExtLock should always be false if CEXT_LOCK is false, since then the lock should never be locked.
graalvmbot
force-pushed
the
bd/run-ractor-safe-exts-in-parallel
branch
from
3f59a2f to
f79582f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.