Skip to content

Add drone config to create artifacts for release #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Salipa-Gurung
Copy link
Collaborator

@Salipa-Gurung Salipa-Gurung commented Sep 23, 2024

Description

Create zip file for release.

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added

@Salipa-Gurung Salipa-Gurung self-assigned this Sep 23, 2024
@Salipa-Gurung Salipa-Gurung force-pushed the drone-zip-artifact branch 5 times, most recently from 2550da3 to d2991f2 Compare September 23, 2024 11:55
@Salipa-Gurung Salipa-Gurung force-pushed the drone-zip-artifact branch 4 times, most recently from 285396b to 45b0383 Compare September 23, 2024 12:16
@Salipa-Gurung Salipa-Gurung force-pushed the drone-zip-artifact branch 16 times, most recently from 67fd7fc to b383b34 Compare September 24, 2024 11:48
@Salipa-Gurung Salipa-Gurung force-pushed the drone-zip-artifact branch 6 times, most recently from 7f991f6 to 82caf70 Compare September 26, 2024 05:07
@saw-jan
Copy link
Member

saw-jan commented Sep 26, 2024

I doubt maybe it's a permission issue (but the same gh token is working for other repos)

@Salipa-Gurung Salipa-Gurung force-pushed the drone-zip-artifact branch 2 times, most recently from 66600ea to 14be880 Compare October 4, 2024 06:10
Copy link

sonarqubecloud bot commented Oct 4, 2024

@Salipa-Gurung Salipa-Gurung marked this pull request as ready for review October 4, 2024 06:15
@koebel
Copy link
Collaborator

koebel commented Nov 25, 2024

Is Docker Image of the app also included in the artifacts?

@saw-jan
Copy link
Member

saw-jan commented Nov 25, 2024

Is Docker Image of the app also included in the artifacts?

docker image should be pushed to the desired container registry (I think we will be using dockerhub)

@koebel
Copy link
Collaborator

koebel commented Nov 25, 2024

docker image should be pushed to the desired container registry (I think we will be using dockerhub)

yes we are using docker hub, see https://hub.docker.com/u/owncloud.
I don't think there is any image for dicom viewer on docker hub yet.

If we follow the same structure/naming conventions like other apps seem to use, it should be https://hub.docker.com/u/owncloud/web-app-dicom-viewer and for the tag dicom-viewer-1.0.0

@CLAassistant
Copy link

CLAassistant commented Nov 25, 2024

CLA assistant check
All committers have signed the CLA.

@koebel
Copy link
Collaborator

koebel commented Nov 27, 2024

there is some work related to creating docker image in #68, please make sure that in the future creating docker image will be included in drone

@mmattel
Copy link
Contributor

mmattel commented Dec 12, 2024

hey @saw-jan any progress on this, respectively if not adding, does this impact rollout?

@koebel
Copy link
Collaborator

koebel commented Dec 12, 2024

@mmattel this issue is related the creation of all artifacts required for future releases, for the current release drone config has been fixed through #69

@Salipa-Gurung Salipa-Gurung force-pushed the drone-zip-artifact branch 3 times, most recently from 1d1e2d6 to ca2be87 Compare April 8, 2025 11:22
Copy link

sonarqubecloud bot commented Apr 8, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants