Skip to content

Add auto-creation of PR for upgrade of MongoDB / Node.js CI env #7186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 27 commits into from

Conversation

mtrezza
Copy link
Member

@mtrezza mtrezza commented Feb 12, 2021

New Pull Request Checklist

Issue Description

Upon fail of ci-self-check a PR has to created manually to update the MongoDB / Node.js versions, before other CI runs pass.

Related issue: closes #7185

Approach

Ci-Self-Check modifies ci.yaml if necessary and commits the change to a new PR.

Side changes

This also moves the lint check out of the mongodb check.

TODOs before merging

  • Add entry to changelog

mtrezza and others added 17 commits November 19, 2020 01:05
* commit 'ccb045b68c5b4d983a90fa125513fc476e4e2387':
  fix: upgrade @graphql-tools/links from 6.2.4 to 6.2.5 (parse-community#7007)
  fix: upgrade pg-promise from 10.7.0 to 10.7.1 (parse-community#7009)
  fix: upgrade jwks-rsa from 1.10.1 to 1.11.0 (parse-community#7008)
  fix: upgrade graphql from 15.3.0 to 15.4.0 (parse-community#7011)
  update stale bot (parse-community#6998)
  fix(beforeSave/afterSave): Return value instead of Parse.Op for nested fields (parse-community#7005)
  fix(beforeSave): Skip Sanitizing Database results (parse-community#7003)
  Fix includeAll for querying a Pointer and Pointer array (parse-community#7002)
  Init (parse-community#6999)
* commit '7f47b0427ea56214d9b0199f0fcfa4af38794e02':
  Add page localization (parse-community#7128)
  Improve contribution guide (parse-community#7075)
  fix: upgrade pg-promise from 10.9.0 to 10.9.1 (parse-community#7170)
  Add tests against multiple MongoDB versions (parse-community#7161)
  fix: upgrade mime from 2.4.7 to 2.5.0 (parse-community#7166)
  fix: upgrade pg-promise from 10.8.7 to 10.9.0 (parse-community#7168)
  fix: upgrade apollo-server-express from 2.19.1 to 2.19.2 (parse-community#7165)
  Upgrade @node-rs/bcrypt to latest version (parse-community#7159)
  Run Prettier after Definitions (parse-community#7164)
@ghost
Copy link

ghost commented Feb 12, 2021

Danger run resulted in 1 warning; to find out more, see the checks page.

Generated by 🚫 dangerJS

@mtrezza mtrezza marked this pull request as draft February 12, 2021 11:31
@codecov
Copy link

codecov bot commented Feb 12, 2021

Codecov Report

Merging #7186 (5b2106e) into master (e53b6c2) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7186      +/-   ##
==========================================
- Coverage   94.03%   93.98%   -0.06%     
==========================================
  Files         172      172              
  Lines       12834    12834              
==========================================
- Hits        12069    12062       -7     
- Misses        765      772       +7     
Impacted Files Coverage Δ
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 92.84% <0.00%> (-0.68%) ⬇️
...dapters/Storage/Postgres/PostgresStorageAdapter.js 95.78% <0.00%> (-0.24%) ⬇️
src/Controllers/SchemaController.js 97.13% <0.00%> (-0.20%) ⬇️
src/RestWrite.js 93.84% <0.00%> (-0.17%) ⬇️
src/Adapters/Files/GridFSBucketAdapter.js 80.32% <0.00%> (+0.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e53b6c2...b19db81. Read the comment docs.

@mtrezza
Copy link
Member Author

mtrezza commented Feb 20, 2021

This is currently in draft because I couldn't find a way around the issue that a GH action in a public repo, triggered by a forked PR, apparently has no write access and therefore cannot create a PR. Still investigating...

@dplewis
Copy link
Member

dplewis commented Apr 15, 2021

I think we should bump the env when we do releases. We could run the CI check on a specific branch like x.x.x for the release.

@mtrezza
Copy link
Member Author

mtrezza commented Apr 15, 2021

I am actually not sure about this because:

  • Bumping this simply requires existing PRs to rebase on master, it's not much different from any other PR that gets merged.
  • We want to automate releases and reduce the effort down to 5 minutes without the requirement to touch any code or make a PR - ideally schedule and fully automate releases some time in 2022.
  • If we shift more work to the time of release we increases the effort required to make a release, which is why releases are currently made only every 4 months.
  • We talk about 1-2 PRs per month, currently total of 10 mins work maybe if done manually.

I am not exactly sure yet at what point into which branch we should do the bump. I think once we have the automated release concept with new branches, we'll know what's best. I suggest to keep this as is for now.

@mtrezza
Copy link
Member Author

mtrezza commented Sep 3, 2021

⚠️ Important change for merging PRs from Parse Server 5.0 onwards!

We are planning to release the first beta version of Parse Server 5.0 in October 2021.

If a PR contains a breaking change and is not merged before the beta release of Parse Server 5.0, it cannot be merged until the end of 2022. Instead it has to follow the Deprecation Policy and phase-in breaking changes to be merged during the course of 2022.

One of the most voiced community feedbacks was the demand for predictability in breaking changes to make it easy to upgrade Parse Server. We have made a first step towards this by introducing the Deprecation Policy in February 2021 that assists to phase-in breaking changes, giving developers time to adapt. We will follow-up with the introduction of Release Automation and a branch model that will allow breaking changes only with a new major release, scheduled for the beginning of each calendar year.

We understand that some PRs are a long time in the making and we very much appreciate your contribution. We want to make it easy for PRs that contain a breaking change and were created before the introduction of the Deprecation Policy. These PRs can be merged with a breaking change without being phased-in before the beta release of Parse Server 5.0. We are making this exception because we appreciate that this is a time of transition that requires additional effort from contributors to adapt. We encourage everyone to prepare their PRs until the end of September and account for review time and possible adaptions.

If a PR contains a breaking change and should be merged before the beta release, please mention @parse-community/server-maintenance and we will coordinate with you to merge the PR.

Thanks for your contribution and support during this transition to Parse Server release automation!

@mtrezza mtrezza closed this Mar 24, 2022
@mtrezza mtrezza deleted the add-auto-pr-for-ci-check branch March 24, 2022 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add auto-creation of PR for upgrade of MongoDB / Node.js CI env
2 participants