Skip to content

Remove /estimates/ecommerce endpoint calls #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

holtbp
Copy link
Contributor

@holtbp holtbp commented Apr 7, 2025

What

Remove calls to /estimates/ecommerce endpoint that does not exist.

Why

Endpoint was removed.

SDK Release Checklist

  • Have you added an integration test for the changes?
  • Have you built the library locally and made queries against it successfully?
  • Did you update the changelog?
  • Did you bump the package version?
  • If endpoints were removed, did you manually remove the corresponding files? (this should be rare)
  • For breaking changes, did you plan for the release of the new SDK versions and deploy the API to production?

@holtbp holtbp requested a review from a team April 7, 2025 17:26
@pcothenet
Copy link
Contributor

@holtbp did you generate from client-code-generation.

This (the failing test on the SDK) is very very not urgent, so feel free to leave this be for now.

@holtbp
Copy link
Contributor Author

holtbp commented Apr 7, 2025

@holtbp did you generate from client-code-generation.

This (the failing test on the SDK) is very very not urgent, so feel free to leave this be for now.

Yes, generated and it seems maybe my pre-commit hook did some formatting here via black locally. I've put this on the back burner atm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants