Skip to content

Add support for Amazon Nova models #929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

tpaulshippy
Copy link

Purpose

Addresses #928

Approach

Add support for Amazon models in AwsBedrock and introduce AwsBedrockAmazonResponse.

Testing

Ran against Nova Micro.
RSpec

@mtrefilek
Copy link
Contributor

@andreibondarev this is looking good to me. Are we able to get test runs going?

@andreibondarev andreibondarev requested a review from Copilot April 17, 2025 18:20
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

lib/langchain/llm/aws_bedrock.rb:305

  • Consider whether additional keys such as :top_p, :top_k, and :stop_sequences should also be removed after merging them into inferenceConfig to avoid potential duplication or inconsistencies in the parameters.
params.reject { |k, _| k == :max_tokens || k == :temperature }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants