Configure Linter for minimum Ruby version compatibility #976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Standard Ruby runs the linter using the runtime Ruby version by default, but developers may use any Ruby version supported by Langchain.rb. This means the linter should work correctly across all supported Ruby versions (3.1+), so it's best to specify the minimum supported version via the `ruby_version: 3.1` setting: https://github.com/standardrb/standard?tab=readme-ov-file#configuring-ruby_version For reference, the Ruby version used in GitHub Actions for linting is currently set to 3.2, so the linter is effectively running under Ruby 3.2 at the moment: https://github.com/patterns-ai-core/langchainrb/blob/0.19.4/.github/workflows/ci.yml#L56 Since the `ruby_version: 3.1` setting takes precedence over the runtime version, this patch would also address that concern.
…sion_compatibility
|
@koic Thank you! Tons of really great changes! |
koic
deleted the
configure_standard_ruby_for_minimum_ruby_version_compatibility
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standard Ruby runs the linter using the runtime Ruby version by default, but developers may use any Ruby version supported by Langchain.rb. This means the linter should work correctly across all supported Ruby versions (3.1+), so it's best to specify the minimum supported version via the
ruby_version: 3.1setting: https://github.com/standardrb/standard?tab=readme-ov-file#configuring-ruby_versionFor reference, the Ruby version used in GitHub Actions for linting is currently set to 3.2, so the linter is effectively running under Ruby 3.2 at the moment: https://github.com/patterns-ai-core/langchainrb/blob/0.19.4/.github/workflows/ci.yml#L56
Since the
ruby_version: 3.1setting takes precedence over the runtime version, this patch would also address that concern.