fix: orderable collection not working when collection has group or tab field #12129
+16
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
There is an issue when Payload uses
postgresAdapter
. If collection is orderable and there is a field that is type ofgroup
ortab
.I cannot replicate the issue in e2e tests and mongoDB but if I use Postgres the issue is there; can you shed some light why is that? Also, how can I run e2e with Postgres db?
Why?
After the group and tab fields are transformed, there is a piece of code that deletes
_order
prop on the root of the document, instead, we should delete_order
in that field.How?
Now, we delete
_order
inref[refKey]
instead on the root document -ref
.