Skip to content

WAM Add #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

WAM Add #349

wants to merge 5 commits into from

Conversation

gaolongsen
Copy link

Hello, I add WAM 7 DOF robot in the package. The model test was without any problem. I look forward to being a contributor to the package!

@petercorke
Copy link
Owner

Hi @gaolongsen thanks for submitting the model, and I apologise for the very long time in responding.

All toolbox models are distributed via PyPI which has quite serious limits on the size of a package, rtb-data is already using "special permission" from the administrators due to is size, and I do need do be conscious of this.

I do not think that the SolidWorks models need to be included here, perhaps include a link to your own repo in a README.md file, that also references the two visualisations you include.

There are inertial parameters in this model, and I think they would be important to people who use a model of a robot like the WAM. Could you add that data?

I hope you can be a contributor to the toolbox.

@gaolongsen
Copy link
Author

Hi Prof. Peter, I have made changes based on all your valuable suggestions. The new version keeps the same structure as other robot models that contains two folders: meshes + urdf. The inertia information for each link of the WAM robot with 7 DoF is included in the file "components.urdf.xacro"; also, for the Barrett hand, the inertia information for all links is in "hand.urdf.xacro". I tested the version in my local environment, and nothing went wrong. I'm looking forward to hearing your feedback and double-checking. Thanks for your time! It's my honor to contribute this pretty powerful tool library!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants