Skip to content

Add OpenWrt router guide #1232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

ihatetoregister
Copy link

Thank you for your contribution to the Pi-hole Community!

Please read the comments below to help us consider your Pull Request.

We are all volunteers and completing the process outlined will help us review your commits quicker.

Please make sure you

  1. Base your code and PRs against the repositories developmental branch.
  2. Sign Off all commits as we enforce the DCO for all contributions
  3. Sign all your commits as they must have verified signatures
  4. File a pull request for any change that requires changes to our documentation at our documentation repo

What does this PR aim to accomplish?:

Add OpenWrt router guide

How does this PR accomplish the above?:

See above

Link documentation PRs if any are needed to support this PR:

N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

Signed-off-by: ihatetoregister <registerihateto@icloud.com>
Copy link

netlify bot commented Apr 17, 2025

Deploy Preview for pihole-docs ready!

Name Link
🔨 Latest commit 391e1eb
🔍 Latest deploy log https://app.netlify.com/sites/pihole-docs/deploys/680d360852e81b00087b04e9
😎 Deploy Preview https://deploy-preview-1232--pihole-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@yubiuser yubiuser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing.

And you need to include the new file in the table of contents in mkdocs.yml

Signed-off-by: ihatetoregister <registerihateto@icloud.com>
Signed-off-by: ihatetoregister <registerihateto@icloud.com>
Signed-off-by: ihatetoregister <registerihateto@icloud.com>
Signed-off-by: ihatetoregister <registerihateto@icloud.com>
Signed-off-by: ihatetoregister <registerihateto@icloud.com>
@@ -0,0 +1,76 @@
# OpenWrt

Here's a short guide to configure Pi-hole as the DNS server for your OpenWrt router.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Here's a short guide to configure Pi-hole as the DNS server for your OpenWrt router.

Here's a short guide to configure Pi-hole as the DNS server for your OpenWrt router.
This guide was written for OpenWrt version 24.10 but the principle should hold for any earlier or later release although Web UI might look different.

## Requirements
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this whole section is not needed. It should be clear that a guide for OpenWrt & Pi-hole requires an OpenWrt router and Pi-hole....

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this image can be cropped. The relevant section is only in the upper quarter of it.

@ihatetoregister
Copy link
Author

sorry not waisting any more time on this, take it or leave it...

@yubiuser
Copy link
Member

Ok, thanks.

@yubiuser yubiuser closed this Apr 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants