Skip to content

Fix missing parameter name updates in documentation and comments #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix missing parameter name updates in documentation and comments #232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion component/rbac.jsonnet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ local aggregated_rbac = [
// argocd-operator's `CONTROLLER_CLUSTER_ROLE` and `SERVER_CLUSTER_ROLE`, cf.
// https://argocd-operator.readthedocs.io/en/latest/usage/custom_roles/
// NOTE(sg): we only deploy these cluster roles if the respective
// `cluster_role_match_labels` parameter in `operator` isn't empty.
// `cluster_role_selectors` parameter in `operator` isn't empty.
local internalControllerAggregationLabel = {
'rbac.argocd.syn.tools/aggregate-to-controller': 'true',
};
Expand Down
4 changes: 2 additions & 2 deletions docs/modules/ROOT/pages/references/parameters.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,12 +410,12 @@ This variable is configured through component parameter `operator.cluster_scope_

[NOTE]
====
When parameter `operator.controller_cluster_role_match_labels` isn't empty, setting `CONTROLLER_CUSTOM_ROLE` through this parameter has no effect.
When parameter `operator.controller_cluster_role_selectors` isn't empty, setting `CONTROLLER_CUSTOM_ROLE` through this parameter has no effect.
====

[NOTE]
====
When parameter `operator.server_cluster_role_match_labels` isn't empty, setting `SERVER_CUSTOM_ROLE` through this parameter has no effect.
When parameter `operator.server_cluster_role_selectors` isn't empty, setting `SERVER_CUSTOM_ROLE` through this parameter has no effect.
====

[IMPORTANT]
Expand Down