-
Notifications
You must be signed in to change notification settings - Fork 235
Set data types for puppetdb parameters #411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
FWIW, I would remove the maintenance label so the change does show up in the change log and release notes. |
As open_ssl_listen_port is no longer |
is there any blocker in getting this PR merged now that's approved? |
Should be good to go, I haven't had a chance to test on live node so I haven't merged. Passing all unit tests. |
Summary:
Enable data type validation for parameters in puppetdb classes and defined types. The goal is to refine user inputs to reduce risk of misconfiguration or failure to apply.
Each data type was configured based on default values supplied within the params.pp class, unit/acceptance tests and alternative values recommended in PuppetDB docs.
Changes:
Stdlib::Host
,Stdlib::Port::User
)Potential for Breaking Change:
Variant
to support historicalString
usage withPattern
matchingRelated Issues:
resolves #105
Testing: