Skip to content

Update Dockerfile.vllm #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 19 additions & 34 deletions .github/workflows/pre-merge-python.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,45 +17,29 @@ name: NVIDIA Test Github Validation

on:
push:
branches:
- main
pull_request:

jobs:
build-test:
runs-on:
group: Fastchecker
runs-on: ubuntu-latest
strategy:
matrix:
framework:
- vllm

name: Build and Test - ${{ matrix.framework }}
env:
CONTAINER_ID: test_${{ github.run_id }}_${{ github.run_attempt }}_${{ github.job }}_${{ matrix.framework }}
PYTEST_XML_FILE: pytest_test_report.xml
PYTEST_MD_FILE: ${{ matrix.framework }}-report.md
PYTEST_XML_FILE: ${{ matrix.framework }}-report.xml
steps:
- name: Checkout repository
uses: actions/checkout@v4
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3
- name: Define Image Tag
id: define_image_tag
run: |
echo "image_tag=dynamo:latest-${{ matrix.framework }}" >> $GITHUB_OUTPUT
- name: Build image
env:
GITHUB_TOKEN: ${{ secrets.CI_TOKEN }}
run: |
./container/build.sh --tag ${{ steps.define_image_tag.outputs.image_tag }} --target ci_minimum --framework ${{ matrix.framework }}
- name: Run pytest
env:
PYTEST_MARKS: "pre_merge or mypy"
run: |
docker run -w /workspace --name ${{ env.CONTAINER_ID }} ${{ steps.define_image_tag.outputs.image_tag }} pytest --basetemp=/tmp --junitxml=${{ env.PYTEST_XML_FILE }} -m "${{ env.PYTEST_MARKS }}"
- name: Copy test report from test Container
- run: |
pip install -r container/deps/requirements.test.txt
pytest -v --md-report --md-report-flavor gfm --md-report-exclude-outcomes passed skipped xpassed --md-report-output ${{ env.PYTEST_MD_FILE }} --junitxml=${{ env.PYTEST_XML_FILE }} success_test.py
- run: ls -al
if: always()
run: |
docker cp ${{ env.CONTAINER_ID }}:/workspace/${{ env.PYTEST_XML_FILE }} .
- name: Archive test report
uses: actions/upload-artifact@v4
if: always()
Expand All @@ -64,14 +48,15 @@ jobs:
if-no-files-found: error
path: |
${{ env.PYTEST_XML_FILE }}
${{ env.PYTEST_MD_FILE }}

event_file:
name: "Event File"
runs-on: ubuntu-latest
if: ${{ github.event_name == 'pull_request' }}
steps:
- name: Upload
uses: actions/upload-artifact@65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08 # v4.6.0
with:
name: Event File
path: ${{ github.event_path }}
# event_file:
# name: "Event File"
# runs-on: ubuntu-latest
# if: ${{ github.event_name == 'pull_request' }}
# steps:
# - name: Upload
# uses: actions/upload-artifact@65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08 # v4.6.0
# with:
# name: Event File
# path: ${{ github.event_path }}
2 changes: 1 addition & 1 deletion container/Dockerfile.vllm
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

ARG BASE_IMAGE="nvcr.io/nvidia/cuda-dl-base"
ARG BASE_IMAGE_TAG="25.01-cuda12.8-devel-ubuntu24.04"

#REMOVE THIS LINE
ARG RUNTIME_IMAGE="nvcr.io/nvidia/cuda"
ARG RUNTIME_IMAGE_TAG="12.8.1-runtime-ubuntu24.04"

Expand Down
10 changes: 10 additions & 0 deletions success_test.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
import pytest

Check notice

Code scanning / CodeQL

Unused import Note

Import of 'pytest' is not used.

Copilot Autofix

AI about 2 months ago

To fix the problem, we need to remove the unused import statement. This will clean up the code and remove the unnecessary dependency on the pytest module. The change should be made in the success_test.py file by deleting the line that imports pytest.

Suggested changeset 1
success_test.py

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/success_test.py b/success_test.py
--- a/success_test.py
+++ b/success_test.py
@@ -1,2 +1 @@
-import pytest
 
EOF
@@ -1,2 +1 @@
import pytest

Copilot is powered by AI and may make mistakes. Always verify output.

def test_passin1():
assert True

def test_passin2():
assert True

def test_passin3():
assert True
Loading