New draw.aaline width algorithm #3191
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds completely new implementation for
draw.aaline
width. Previous implementation (#3140) uses Bresenham's algorithm, and because of that, line cant be drawn at float coordinates (they are converted to ints instead).New implementation uses modified Xiaolin Wu's algorithm that allows drawing at float coordinates, and is faster.
Old width implementation is removed for pgce 2.5.2 in #3192
How it works
Original
draw_aaline
code is used, heavily modified:drawhorzlineclipbounding
and newdrawvertlineclipbounding
to handle special cases when drawing lines outside surface.Sample code