run_in_pyodide: Add handling for when requested packages are not built #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* When running outside of pytest, raise a RuntimeError * When running in pytest locally, skip the test * When running in pytest in CI, fail the test Can configure whether we want the test to be skipped or failed with the `skip_if_not_all_built` argument.
hoodmane
force-pushed
the
skip-if-not-all-built
branch
from
b18ee17 to
b8fd16e
Compare
ryanking13
reviewed
Mar 24, 2025
| @@ -383,6 +384,7 @@ def __init__( | |||
| packages: Collection[str] = (), | |||
| pytest_assert_rewrites: bool = True, | |||
| *, | |||
| skip_if_not_all_built: bool = "CI" in os.environ, | |||
There was a problem hiding this comment.
I think setting the default to "CI" in os.environ might be confusing to users, as they will silently get different behavior in local and in CI. How about 1) setting the default to False, and make it configurable in the CLI option
There was a problem hiding this comment.
Makes sense. Also, it seems that what we really want is to skip if it's in one of the earlier test jobs (e.g., test_packages_no_numpy_dependents) but fail if it's in the final job.
There was a problem hiding this comment.
if it's in one of the earlier test jobs (e.g., test_packages_no_numpy_dependents) but fail if it's in the final job.
Yeah, makes sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can configure whether we want the test to be skipped or failed with the
skip_if_not_all_builtargument.