Skip to content

gh-132493: lazy evaluation of annotations in typing._proto_hook #132534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions Lib/test/test_typing.py
Original file line number Diff line number Diff line change
Expand Up @@ -4554,6 +4554,33 @@ class Commentable(Protocol):
)
self.assertIs(type(exc.__cause__), CustomError)

def test_isinstance_with_deferred_evaluation_of_annotations(self):
@runtime_checkable
class P(Protocol):
def meth(self):
...

class DeferredClass:
x: undefined

class DeferredClassImplementingP:
x: undefined | int

def __init__(self):
self.x = 0

def meth(self):
...

# override meth with a non-method attribute to make it part of __annotations__ instead of __dict__
class SubProtocol(P, Protocol):
meth: undefined


self.assertIsSubclass(SubProtocol, P)
self.assertNotIsInstance(DeferredClass(), P)
self.assertIsInstance(DeferredClassImplementingP(), P)

def test_deferred_evaluation_of_annotations(self):
class DeferredProto(Protocol):
x: DoesNotExist
Expand Down
11 changes: 7 additions & 4 deletions Lib/typing.py
Original file line number Diff line number Diff line change
Expand Up @@ -2020,10 +2020,13 @@ def _proto_hook(cls, other):
break

# ...or in annotations, if it is a sub-protocol.
annotations = getattr(base, '__annotations__', {})
if (isinstance(annotations, collections.abc.Mapping) and
attr in annotations and
issubclass(other, Generic) and getattr(other, '_is_protocol', False)):
if (
issubclass(other, Generic)
and getattr(other, "_is_protocol", False)
and attr in _lazy_annotationlib.get_annotations(
base, format=_lazy_annotationlib.Format.FORWARDREF
)
):
break
else:
return NotImplemented
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
:class:`typing.Protocol` now uses :func:`annotationlib.get_annotations` when
checking whether or not an instance implements the protocol with
:func:`isinstance`. This enables support for ``isinstance`` checks against
classes with deferred annotations.
Loading