Skip to content

fix pyscreeze.locateCenterOnScreen #13852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

brasswood
Copy link

Give parameter minSearchTime a default value of 0 in function pyscreeze.locateCenterOnScreen. This should be okay because in the actual library, locateCenterOnScreen just delegates all of its parameters to locateOnScreen, and the type definition here for locateOnScreen gives minSearchTime a default value of 0.

Fixes #13851

give parameter minSearchTime a default value of 0 in function pyscreeze.locateCenterOnScreen.

This comment has been minimized.

Copy link
Author

@brasswood brasswood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that catch

Copy link
Contributor

Diff from mypy_primer, showing the effect of this PR on open source code:

vision (https://github.com/pytorch/vision)
- torchvision/utils.py:271: error: Unused "type: ignore" comment  [unused-ignore]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pyscreeze.locateCenterOnScreen should not require minSearchTime parameter
2 participants