Skip to content

Add a structseq class to _typeshed #6560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 82 commits into from
Dec 17, 2021
Merged

Conversation

AlexWaygood
Copy link
Member

Fixes #6546.

@github-actions
Copy link
Contributor

Diff from mypy_primer, showing the effect of this PR on open source code:

mypy (https://github.com/python/mypy)
+ mypy/fscache.py:149: error: unused "type: ignore" comment

Co-authored-by: Akuli <akuviljanen17@gmail.com>
Copy link
Collaborator

@Akuli Akuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'll wait for another maintainer to merge this, in case someone else wants to review it too.

@github-actions
Copy link
Contributor

Diff from mypy_primer, showing the effect of this PR on open source code:

mypy (https://github.com/python/mypy)
+ mypy/fscache.py:149: error: unused "type: ignore" comment

@github-actions
Copy link
Contributor

Diff from mypy_primer, showing the effect of this PR on open source code:

mypy (https://github.com/python/mypy)
+ mypy/fscache.py:149: error: unused "type: ignore" comment

3 similar comments
@github-actions
Copy link
Contributor

Diff from mypy_primer, showing the effect of this PR on open source code:

mypy (https://github.com/python/mypy)
+ mypy/fscache.py:149: error: unused "type: ignore" comment

@github-actions
Copy link
Contributor

Diff from mypy_primer, showing the effect of this PR on open source code:

mypy (https://github.com/python/mypy)
+ mypy/fscache.py:149: error: unused "type: ignore" comment

@github-actions
Copy link
Contributor

Diff from mypy_primer, showing the effect of this PR on open source code:

mypy (https://github.com/python/mypy)
+ mypy/fscache.py:149: error: unused "type: ignore" comment

@AlexWaygood
Copy link
Member Author

Friendly ping :)

Any chance of getting of getting this merged?

@github-actions
Copy link
Contributor

Diff from mypy_primer, showing the effect of this PR on open source code:

mypy (https://github.com/python/mypy)
+ mypy/fscache.py:148: error: unused "type: ignore" comment

@JelleZijlstra JelleZijlstra merged commit 0b75d71 into python:master Dec 17, 2021
@AlexWaygood AlexWaygood deleted the structseq branch December 17, 2021 21:43
@AlexWaygood
Copy link
Member Author

Thanks, everybody! 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Weird n_fields attributes, etc.
5 participants