modules/exploits/solaris: Resolve RuboCop violations #20073
+1,125
−1,083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcoles
force-pushed
the
rubocop-modules-exploits-solaris
branch
from
0583bd0 to
0ef9f30
Compare
adfoster-r7
reviewed
Apr 23, 2025
| end | ||
|
|
||
|
|
||
| def exploit |
There was a problem hiding this comment.
Does this exploit still work if the autocheck's skip check datastore option is set?
There was a problem hiding this comment.
I don't have SPARC hardware to test, but yes, is should. The check function doesn't set up anything required by the remainder of the module. spc_connect is called within attack within the exploit method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most violations were resolved with
rubocop -A, except notes.The RSH stack clash module needs some work to move the C source into a standalone file in
external/, but this is outside the scope of this PR.