breaking changes for nvim 0.11 #320
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements breaking changes for nvim 0.11 by deprecating legacy LSP setup methods and updating documentation and CI configurations accordingly.
- Removed deprecated on_attach and language-specific LSP configurations in the README.
- Updated instructions regarding mason and added guidance for using LspAttach autocmd.
- Updated the CI workflow to use nvim 0.11 and Go 1.24.0.
Reviewed Changes
Copilot reviewed 20 out of 38 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| README.md | Updated documentation to reflect breaking changes in LSP setup. |
| .github/workflows/ci.yml | Updated version references for nvim and Go to align with nvim 0.11. |
Files not reviewed (18)
- Makefile: Language not supported
- doc/navigator.txt: Language not supported
- lsp/ccls.lua: Language not supported
- lsp/clangd.lua: Language not supported
- lsp/gopls.lua: Language not supported
- lsp/jdtls.lua: Language not supported
- lsp/lua_ls.lua: Language not supported
- lsp/luals.lua: Language not supported
- lsp/omnisharp.lua: Language not supported
- lsp/pyright.lua: Language not supported
- lsp/ruff.lua: Language not supported
- lsp/rust_analyzer.lua: Language not supported
- lua/navigator.lua: Language not supported
- lua/navigator/codeAction.lua: Language not supported
- lua/navigator/codelens.lua: Language not supported
- lua/navigator/definition.lua: Language not supported
- lua/navigator/diagnostics.lua: Language not supported
- lua/navigator/dochighlight.lua: Language not supported
Comments suppressed due to low confidence (1)
README.md:547
- [nitpick] The word 'longger' appears to be a misspelling. Please correct it to 'longer' for consistency and clarity.
Note: mason lspconfig no longger support as of nvim 0.11 The only change you need in in LspAttach event add if you prefer to use mason lspconfig
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0.11 has changed the way we setup lsp.
This branch is a dev branch on tip and will move to tip in a few months when lspconfig deprecate setup{} method.